[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/184 @anmolnar thanks for the hard work! Our plan is to run this on a real cluster for about a month, if everything is working well, that will be a pretty good argument for "this code is ready to be

ZooKeeper-trunk - Build # 78 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk/78/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 142.23 KB...] [junit] Tests run: 1, Failures: 0, Errors:

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

Hi Pat, Yes please hold off reviewing. A quick look indicates that this RC is problematic in terms of the C client build files - I don't know what happened as I was following standard release protocol. I'll investigate a little bit more, and cut a new RC before next Monday. On Wed, Jun 27, 2018

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

Given this has a -1 should I hold off reviewing? Michael what are you planning to do? Cut another RC? Patrick On Wed, Jun 27, 2018 at 7:17 AM Norbert Kalmar wrote: > +1 (non-binding) > > Built from source (release-3.4.13-rc0 tag), run in standalone, cluster of > 3, runed basic commands

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/466 Currently listed as having a conflict, @anmolnar can you update the patch? ---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/549#discussion_r198607891 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java --- @@ -103,6 +103,23 @@ public void testCustomSSLAuth()

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/549#discussion_r198607295 --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java --- @@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean testLeader)

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/549#discussion_r198609106 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr)

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

On Mon, Jun 25, 2018 at 10:34 PM Michael Han wrote: > Since pkg-config has been available for a long time, what's the drawback in > terms of compatibilities if we choose only support pkg-config moving > forward? > > It could break existing downstream build infra. Also the issue is not super

[jira] [Commented] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525329#comment-16525329 ] Christine Poerschke commented on ZOOKEEPER-3061: Thanks [~maoling] for the question

ZooKeeper_branch34_openjdk7 - Build # 1973 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1973/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.77 KB...] [junit] Running

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user tamaashu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/549#discussion_r198532231 --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java --- @@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

+1 (non-binding) Built from source (release-3.4.13-rc0 tag), run in standalone, cluster of 3, runed basic commands (create, get,set, delete etc.). MacOS 10.13.4 Thanks, Norbert On Wed, Jun 27, 2018 at 3:45 PM Andor Molnar wrote: > + tested with different cluster sizes: 1,3,5,7 > + verified a

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

+ tested with different cluster sizes: 1,3,5,7 + verified a few 4lw commands + verified JMX interface Regards, Andor On Wed, Jun 27, 2018 at 2:51 PM, Andor Molnar wrote: > Hi Michael, > > Thanks for putting together this new release. > > My vote: -1 > > I've run the following tests so far: >

[GitHub] zookeeper issue #553: continue can be replaced with break

Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/553 Thanks @a470577391 , possibly OK, but please create a jira for this PR on https://issues.apache.org/jira/projects/ZOOKEEPER/ And make sure the jira number is in the commit message. ---

[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/353 @phunt Would you like to take a quick look? You worked on the patch for ZOOKEEPER-710. ---

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

Hi Michael, Thanks for putting together this new release. My vote: -1 I've run the following tests so far: + signatures verified + java unit tests successful - unable to build C client / C++ unit tests, because ./configure script is not executable BUILD FAILED

Success: ZOOKEEPER- PreCommit Build #1883

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1883/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.33 MB...] [exec] +1

[GitHub] zookeeper pull request #553: continue can be replaced with break

GitHub user a470577391 opened a pull request: https://github.com/apache/zookeeper/pull/553 continue can be replaced with break FileTxnLog.getLogFiles() continue can be replaced with break You can merge this pull request into a Git repository by running: $ git pull

ZooKeeper_branch35_jdk8 - Build # 1020 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1020/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.96 KB...] [junit] Tests run: 1, Failures:

Success: ZOOKEEPER- PreCommit Build #1882

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1882/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.69 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3022) Step 1 - Separate project structure

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524919#comment-16524919 ] Hadoop QA commented on ZOOKEEPER-3022: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #1881

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1881/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.86 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3022) Step 1 - Separate project structure

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524882#comment-16524882 ] Hadoop QA commented on ZOOKEEPER-3022: -- +1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper pull request #552: ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration ...

GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/552 ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration 1 - docs, it Maven migration - first iteration (zookeeper-docs and zookeeper-it), branch 3.4 You can merge this pull request into a Git repository

[GitHub] zookeeper pull request #551: ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration ...

Github user nkalmar closed the pull request at: https://github.com/apache/zookeeper/pull/551 ---

[GitHub] zookeeper pull request #551: ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration ...

GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/551 ZOOKEEPER-3022 MAVEN MIGRATION 3.4 - Iteration 1 - docs, it This is the backport to 3.4 on the maven migration, first iteration (zookeeper-docs and zookeeper-it folder for future sub-modules)

Success: ZOOKEEPER- PreCommit Build #1880

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1880/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.05 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2873) print error and/or abort on invalid server definition

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524808#comment-16524808 ] Hadoop QA commented on ZOOKEEPER-2873: -- +1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper issue #550: ZOOKEEPER-3022 - Iteration 1 - docs, it

Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/550 You're right @anmolnar , I also realised after seeing the PR that I should have added some text indicating this is part of the migration. I will add it in the future, thanks. ---

[GitHub] zookeeper issue #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/549 Doesn't the merge script do a squash? ---

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/549#discussion_r198408262 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java --- @@ -103,6 +103,23 @@ public void testCustomSSLAuth()

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/549#discussion_r198407883 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -259,6 +259,11 @@ public QuorumServer(long sid, String addressStr)

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/549#discussion_r198405834 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java --- @@ -103,6 +103,23 @@ public void testCustomSSLAuth()

[GitHub] zookeeper pull request #549: ZOOKEEPER-2873 abort startup on invalid ports

Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/549#discussion_r198404697 --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigTest.java --- @@ -801,10 +801,12 @@ private void testPortChangeToBlockedPort(boolean

Re: Maven migration doc - thoughts and suggestions

Hi, Heads-up for everybody: The migration project has been started with the first PR according to the design docs. Please try to make some effort taking a quick look and give feedback. Thanks, Andor On Thu, Jun 14, 2018 at 2:17 PM, Norbert Kalmar < nkal...@cloudera.com.invalid> wrote: >

[GitHub] zookeeper issue #550: ZOOKEEPER-3022 - Iteration 1 - docs, it

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/550 Thanks @nkalmar, looks good to me. One nitpick only: add "MAVEN MIGRATION" to the title of all these PRs in capitals, just to make it obvious for everybody that you're making progress. ---

[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota

[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524612#comment-16524612 ] Andor Molnar commented on ZOOKEEPER-451: Thanks [~plsnotracking] for testing. Are you willing