[GitHub] zookeeper pull request #533: ZOOKEEPER-2989:IPv6 literal address causes prob...

2018-07-11 Thread maoling
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/533 ---

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 1

2018-07-11 Thread Michael Han
Thanks Pat for confirmation. I'll leave the rest of the week for folks to try the release candidate and provide feedback. As Pat mentioned, helping voting a release is a great way to make contributions to ZooKeeper, so any help will be very welcome! I'll start publish the new release early next

[GitHub] zookeeper pull request #534: ZOOKEEPER-2184 Zookeeper Client should re-resol...

2018-07-11 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/534#discussion_r201894799 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -149,15 +185,12 @@ public StaticHostProvider(Collection serverAddresses,

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 1

2018-07-11 Thread Patrick Hunt
Your vote counts - 3 +1 from PMC is all we need. Would be great to see some of the other folks vote though. Patrick On Wed, Jul 11, 2018 at 6:54 PM Michael Han wrote: > Thanks Pat! > > Just double check, a release requires at least three binding (PMC) votes, > right? I guess my own vote (as

ZooKeeper_branch34_jdk7 - Build # 1989 - Failure

2018-07-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1989/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.25 KB...] [junit] Running

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 1

2018-07-11 Thread Michael Han
Thanks Pat! Just double check, a release requires at least three binding (PMC) votes, right? I guess my own vote (as the release manager) does not count, so we need one more vote from a PMC member before we can release this (currently two bindings are from you and Rakesh). On Wed, Jul 11, 2018

ZooKeeper_branch35_jdk8 - Build # 1036 - Failure

2018-07-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1036/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.90 KB...] [junit] Running

[GitHub] zookeeper pull request #521: ZOOKEEPER-3042: testFailedTxnAsPartOfQuorumLoss...

2018-07-11 Thread lavacat
Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/521 ---

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-07-11 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/466 +1, lgtm. Also tried running against a runtime cluster and it worked ok. committed to 3.5.5 and master. Thanks @anmolnar . ---

[jira] [Resolved] (ZOOKEEPER-2940) Deal with maxbuffer as it relates to large requests from clients

2018-07-11 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-2940. - Resolution: Fixed Fix Version/s: 3.5.5 3.6.0 Issue

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/466 ---

ZooKeeper-trunk - Build # 96 - Failure

2018-07-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/96/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 142.50 KB...] [junit] Tests run: 1, Failures: 0, Errors:

ZooKeeper_branch34_jdk8 - Build # 1458 - Failure

2018-07-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1458/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.00 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-3057) Fix IPv6 literal usage

2018-07-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540812#comment-16540812 ] Hadoop QA commented on ZOOKEEPER-3057: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1929

2018-07-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1929/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.86 MB...] [exec] +1

[jira] [Updated] (ZOOKEEPER-1859) pwriter should be closed in NIOServerCnxn#checkFourLetterWord()

2018-07-11 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated ZOOKEEPER-1859: -- Description: {code} final PrintWriter pwriter = new PrintWriter( new

[GitHub] zookeeper issue #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-11 Thread mjeelanimsft
Github user mjeelanimsft commented on the issue: https://github.com/apache/zookeeper/pull/548 @anmolnar Resolved the merge conflict. You can see the commit with the unit test changes here - https://github.com/apache/zookeeper/pull/548/commits/ff4704984203921071877bdee4efef47b8c2a706

Failed: ZOOKEEPER- PreCommit Build #1928

2018-07-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1928/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 2.29 KB...] stderr: Also:

[GitHub] zookeeper issue #534: ZOOKEEPER-2184 Zookeeper Client should re-resolve host...

2018-07-11 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/534 @lvfangmin Unit tests failed, but it seems like we also introduced a findbug issue with #562 Shall I fix it in this patch or would you like to do it separately? ---

Failed: ZOOKEEPER- PreCommit Build #1927

2018-07-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1927/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.91 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

2018-07-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540621#comment-16540621 ] Hadoop QA commented on ZOOKEEPER-2184: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-3062) mention fsync.warningthresholdms in FileTxnLog LOG.warn message

2018-07-11 Thread Christine Poerschke (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540583#comment-16540583 ] Christine Poerschke commented on ZOOKEEPER-3062: bq. ... Findbugs warnings:

Failed: ZOOKEEPER- PreCommit Build #1926

2018-07-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1926/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.02 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3062) mention fsync.warningthresholdms in FileTxnLog LOG.warn message

2018-07-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540578#comment-16540578 ] Hadoop QA commented on ZOOKEEPER-3062: -- -1 overall. GitHub Pull Request Build +1

[jira] [Updated] (ZOOKEEPER-3062) mention fsync.warningthresholdms in FileTxnLog LOG.warn message

2018-07-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3062: -- Labels: pull-request-available (was: ) > mention fsync.warningthresholdms in

[GitHub] zookeeper pull request #566: ZOOKEEPER-3062: mention fsync.warningthresholdm...

2018-07-11 Thread cpoerschke
GitHub user cpoerschke opened a pull request: https://github.com/apache/zookeeper/pull/566 ZOOKEEPER-3062: mention fsync.warningthresholdms in FileTxnLog LOG.warn message https://issues.apache.org/jira/browse/ZOOKEEPER-3062 You can merge this pull request into a Git repository by

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 1

2018-07-11 Thread Patrick Hunt
+1. the xsum/sig are good. rat seemed fine. ran through a number of cluster scenarios and it seemed to work fine. I notice that the dynamic IP change is in - I'd recommend folks that have been advocating for that change to give the RC a try and verify that it's working for them. Great way to pay

Failed: ZOOKEEPER- PreCommit Build #1924

2018-07-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1924/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84.95 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #1925

2018-07-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1925/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 35.14 KB...] [exec]

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

2018-07-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540221#comment-16540221 ] Hadoop QA commented on ZOOKEEPER-2184: -- -1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper pull request #534: ZOOKEEPER-2184 Zookeeper Client should re-resol...

2018-07-11 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/534#discussion_r201723327 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -149,15 +185,12 @@ public StaticHostProvider(Collection

[GitHub] zookeeper issue #456: ZOOKEEPER-2930: Leader cannot be elected due to networ...

2018-07-11 Thread JonathanO
Github user JonathanO commented on the issue: https://github.com/apache/zookeeper/pull/456 Rebased on top of latest master. ---

[GitHub] zookeeper issue #465: ZOOKEEPER-2930: Leader cannot be elected due to networ...

2018-07-11 Thread JiangJiafu
Github user JiangJiafu commented on the issue: https://github.com/apache/zookeeper/pull/465 Will this patch be merged to 3.4 branch? ---

[jira] [Updated] (ZOOKEEPER-2930) Leader cannot be elected due to network timeout of some members.

2018-07-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2930: -- Labels: pull-request-available (was: ) > Leader cannot be elected due to network

[GitHub] zookeeper issue #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-11 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/548 @mjeelanimsft I keep trying to refresh the page, but again I can't see the new tests. Also the patch has some conflicts with the latest master, would you please resolve them? ---

[jira] [Commented] (ZOOKEEPER-3084) Exit when ZooKeeper cannot bind to the leader election port

2018-07-11 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539817#comment-16539817 ] Andor Molnar commented on ZOOKEEPER-3084: - [~lvfangmin] Would you please kindly create a

[GitHub] zookeeper pull request #561: ZOOKEEPER-3083: Remove some redundant and noisy...

2018-07-11 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/561#discussion_r201620682 --- Diff: src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java --- @@ -124,9 +124,7 @@ private void unregister(String path,ZKMBeanInfo bean) throws