[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

2018-07-19 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r203940477 --- Diff: src/java/main/org/apache/zookeeper/KeeperException.java --- @@ -387,6 +389,8 @@ public void setCode(int code) {

[jira] [Commented] (ZOOKEEPER-2251) Add Client side packet response timeout to avoid infinite wait.

2018-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550168#comment-16550168 ] Hadoop QA commented on ZOOKEEPER-2251: -- -1 overall. Here are the results of testing the latest

Failed: ZOOKEEPER-2251 PreCommit Build #3698

2018-07-19 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2251 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3698/ ### ## LAST 60 LINES OF THE CONSOLE ###

[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

2018-07-19 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r203928468 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1495,10 +1504,21 @@ public ReplyHeader submitRequest(RequestHeader h, Record

[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

2018-07-19 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r203928395 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -1495,10 +1504,21 @@ public ReplyHeader submitRequest(RequestHeader h, Record

[GitHub] zookeeper pull request #119: ZOOKEEPER-2251:Add Client side packet response ...

2018-07-19 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/119#discussion_r203928289 --- Diff: src/java/main/org/apache/zookeeper/KeeperException.java --- @@ -387,6 +389,8 @@ public void setCode(int code) {

ZooKeeper-trunk - Build # 112 - Failure

2018-07-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/112/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 142.79 KB...] [junit] Tests run: 1, Failures: 0,

[GitHub] zookeeper issue #563: ZOOKEEPER-3072: Throttle race condition fix

2018-07-19 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/563 Thanks @bothejjms . I think the patch can be accepted now without the test. We need at least one more committer to approve. @hanm @phunt ? ---

[jira] [Issue Comment Deleted] (ZOOKEEPER-451) ZK should enforce quota

2018-07-19 Thread Vi (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vi updated ZOOKEEPER-451: - Comment: was deleted (was: Hello, I see this feature had a patch which did not make it through. Any reason

Re: Trying to find pattern in Flaky Tests

2018-07-19 Thread Molnár Andor
Sorry guys for this aweful email. Looks like Apache converted my nicely illustrated email into plain text. :( Maybe I could attach the test reports as images, but I think you already got the idea. Andor On 07/18/2018 05:42 PM, Andor Molnar wrote: > Hi, > > *branch-3.4* > > I've taken a quick

Re: Trying to find pattern in Flaky Tests

2018-07-19 Thread Andor Molnár
Thanks Pat for fixing the report. Very useful. I think it was unable to retrieve the test report, because there was no test report available for those builds at the time it was running. We might want to expose the error code in the below logs, but if you take a look at #104 and #100: test report

Re: Trying to find pattern in Flaky Tests

2018-07-19 Thread Andor Molnár
Thanks Bogdan. Your analysis is much appreciated. According to your findings, it looks like it must be an infrastructure issue. But that doesn't explain why the test is a lot more stable on the 3.4 branch. I'd like to setup new jenkins jobs on a private infrastructure (other than Apache) on

[jira] [Commented] (ZOOKEEPER-3046) testManyChildWatchersAutoReset is flaky

2018-07-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549685#comment-16549685 ] Hudson commented on ZOOKEEPER-3046: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #111 (See

[jira] [Commented] (ZOOKEEPER-3077) Build native C library outside of source directory

2018-07-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549686#comment-16549686 ] Hudson commented on ZOOKEEPER-3077: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #111 (See

[jira] [Commented] (ZOOKEEPER-3093) sync zerror(int rc) with newest error definitions

2018-07-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549687#comment-16549687 ] Hudson commented on ZOOKEEPER-3093: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #111 (See

[jira] [Commented] (ZOOKEEPER-3057) Fix IPv6 literal usage

2018-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549671#comment-16549671 ] Hadoop QA commented on ZOOKEEPER-3057: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1973

2018-07-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1973/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.30 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #1972

2018-07-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1972/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 6.50 KB...] [exec]

[GitHub] zookeeper issue #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-19 Thread mjeelanimsft
Github user mjeelanimsft commented on the issue: https://github.com/apache/zookeeper/pull/548 Thanks for the feedback @maoling - I've incorporated the below changes. @maoling @anmolnar - let me know what you think - Assert actual host and port in unit tests for getHostAndPort

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-19 Thread mjeelanimsft
Github user mjeelanimsft commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r203817750 --- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java --- @@ -61,10 +61,16 @@ static public String getClientConfigStr(String

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

2018-07-19 Thread mjeelanimsft
Github user mjeelanimsft commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/548#discussion_r203816489 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java --- @@ -857,15 +869,15 @@ public void run() {

[GitHub] zookeeper issue #47: Update zookeeperOver.html

2018-07-19 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/47 @cpoerschke please close this given your recent comment. thanks. ---

[GitHub] zookeeper issue #350: fix comment type error.

2018-07-19 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/350 @cpoerschke can you close this PR given your comment re #554 and the fact that it's been committed? Thanks. ---

[GitHub] zookeeper issue #575: ZOOKEEPER-3093 sync zerror with ZOO_ERRORS

2018-07-19 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/575 +1, LGTM. Nice catch @sl4mmy . Consider submitting a PR to add a comment to the bottom of ZOO_ERRORS warning folks that they should also update zerror(...) if they change/add to the enum. ---

[jira] [Resolved] (ZOOKEEPER-3093) sync zerror(int rc) with newest error definitions

2018-07-19 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-3093. - Resolution: Fixed Issue resolved by pull request 575

[GitHub] zookeeper pull request #575: ZOOKEEPER-3093 sync zerror with ZOO_ERRORS

2018-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/575 ---

[jira] [Updated] (ZOOKEEPER-3093) sync zerror(int rc) with newest error definitions

2018-07-19 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3093: Fix Version/s: 3.5.5 3.6.0 > sync zerror(int rc) with newest error

[jira] [Updated] (ZOOKEEPER-3093) sync zerror(int rc) with newest error definitions

2018-07-19 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3093: Affects Version/s: 3.6.0 3.5.4 > sync zerror(int rc) with

Failed: ZOOKEEPER- PreCommit Build #1971

2018-07-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1971/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 127.95 KB...] CONFLICT (content):

[GitHub] zookeeper issue #557: ZOOKEEPER-3077: build outside of source directory

2018-07-19 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/557 +1, LGTM. Worked fine testing on ubuntu/master. Thanks @sl4mmy ! ---

[jira] [Resolved] (ZOOKEEPER-3077) Build native C library outside of source directory

2018-07-19 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-3077. - Resolution: Fixed Issue resolved by pull request 557

[GitHub] zookeeper pull request #557: ZOOKEEPER-3077: build outside of source directo...

2018-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/557 ---

[jira] [Updated] (ZOOKEEPER-3077) Build native C library outside of source directory

2018-07-19 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3077: Affects Version/s: 3.6.0 3.4.13 > Build native C library

[jira] [Updated] (ZOOKEEPER-3077) Build native C library outside of source directory

2018-07-19 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-3077: Fix Version/s: 3.4.14 3.5.5 3.6.0 > Build native

[jira] [Assigned] (ZOOKEEPER-3077) Build native C library outside of source directory

2018-07-19 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-3077: --- Assignee: Kent R. Spillner > Build native C library outside of source directory

Failed: ZOOKEEPER- PreCommit Build #1970

2018-07-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1970/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 128.10 KB...] CONFLICT (content):

[jira] [Commented] (ZOOKEEPER-3046) testManyChildWatchersAutoReset is flaky

2018-07-19 Thread Patrick Hunt (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549557#comment-16549557 ] Patrick Hunt commented on ZOOKEEPER-3046: - This is an odd one. I committed the PR 576, let's

[GitHub] zookeeper issue #576: ZOOKEEPER-3046: increased test timeout

2018-07-19 Thread phunt
Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/576 Seems worth a try, +1. Thanks @lavacat . Let's continue to keep an eye on this one. ---

[GitHub] zookeeper pull request #576: ZOOKEEPER-3046: increased test timeout

2018-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/576 ---

ZooKeeper_branch34_openjdk7 - Build # 1994 - Failure

2018-07-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1994/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.76 KB...] [junit] Running

[jira] [Updated] (ZOOKEEPER-3091) Prometheus /metrics http endpoint for monitoring integration

2018-07-19 Thread Hari Sekhon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Sekhon updated ZOOKEEPER-3091: --- Description: Feature Request to add Prometheus /metrics http endpoint for monitoring

[jira] [Updated] (ZOOKEEPER-3091) Prometheus /metrics http endpoint for monitoring integration

2018-07-19 Thread Hari Sekhon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Sekhon updated ZOOKEEPER-3091: --- Description: Feature Request to add Prometheus /metrics http endpoint for monitoring

[jira] [Commented] (ZOOKEEPER-3085) Define constant exit code and add documents

2018-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549032#comment-16549032 ] Hadoop QA commented on ZOOKEEPER-3085: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1969

2018-07-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1969/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.47 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3085) Define constant exit code and add documents

2018-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549021#comment-16549021 ] Hadoop QA commented on ZOOKEEPER-3085: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #1968

2018-07-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1968/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.53 MB...] [exec] +1

Success: ZOOKEEPER- PreCommit Build #1967

2018-07-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1967/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.44 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3072) Race condition in throttling

2018-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549008#comment-16549008 ] Hadoop QA commented on ZOOKEEPER-3072: -- +1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper pull request #572: ZOOKEEPER-3085 define exit codes in enum

2018-07-19 Thread nkalmar
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/572#discussion_r203643727 --- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java --- @@ -20,8 +20,35 @@ /** * Exit code used to exit server */

[GitHub] zookeeper issue #576: ZOOKEEPER-3046: increased test timeout

2018-07-19 Thread lavacat
Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/576 @lvfangmin Do you mean 10 mins (60 ms)? That was me who set it before. The story of this is: this test was timing out sometimes under normal ant limits (15 mins). When ant kills the test

Success: ZOOKEEPER- PreCommit Build #1966

2018-07-19 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1966/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.29 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3046) testManyChildWatchersAutoReset is flaky

2018-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1654#comment-1654 ] Hadoop QA commented on ZOOKEEPER-3046: -- +1 overall. GitHub Pull Request Build +1

Re: Trying to find pattern in Flaky Tests

2018-07-19 Thread Bogdan Kanivets
Hi Andor, For testManyChildWatchersAutoReset, that was me who put 10min timeout on the test itself. I wanted to see the logs and the problem is that when test is timed out by ant (default 15min) logs aren't captured. I agree that it became much flakier. I've pushed the PR right now to increase to

[GitHub] zookeeper issue #576: ZOOKEEPER-3046: increased test timeout

2018-07-19 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/576 Is 3.5 taking longer time to run this test? looks like it was set to 60s in the other pull request. ---

[GitHub] zookeeper pull request #576: ZOOKEEPER-3046: increased test timeout

2018-07-19 Thread lavacat
GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/576 ZOOKEEPER-3046: increased test timeout - bump up timeout to avoid too many build failures You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (ZOOKEEPER-3046) testManyChildWatchersAutoReset is flaky

2018-07-19 Thread Bogdan Kanivets (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548844#comment-16548844 ] Bogdan Kanivets commented on ZOOKEEPER-3046: [~hanm] [~phunt] I've done some digging

ZooKeeper_branch35_jdk8 - Build # 1046 - Still Failing

2018-07-19 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1046/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.95 KB...] [junit] Running