Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205933566
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205933558
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560592#comment-16560592
]
Hudson commented on ZOOKEEPER-3061:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #125 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560594#comment-16560594
]
Hudson commented on ZOOKEEPER-3095:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #125 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560593#comment-16560593
]
Hudson commented on ZOOKEEPER-3072:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #125 (See
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/579
hey @mjeelanimsft when i did the commit, your email address came up wrong.
i think i fixed it, but you might want to check your git config.
thanx for the submission!
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3095.
--
Resolution: Fixed
Issue resolved by pull request 579
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/579
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/583
ok @lvfangmin i'll commit this once the conflict is resolved.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3072.
--
Resolution: Fixed
> Race condition in throttling
>
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed updated ZOOKEEPER-3072:
-
Fix Version/s: 3.5.4
3.6.0
> Race condition in throttling
>
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/563
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3061.
--
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 555
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/555
---
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205924496
--- Diff: src/c/tests/zkServer.sh ---
@@ -77,7 +77,7 @@ fi
if [ "x${base_dir}" == "x" ]
then
-zk_base="../../"
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205922937
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java ---
@@ -85,31 +85,43 @@ public boolean isGlobalSession(long
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205922808
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
---
@@ -280,6 +275,11 @@ public synchronized boolean addSession(long id,
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205922968
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTracker.java ---
@@ -47,21 +47,20 @@
long createSession(int sessionTimeout);
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205923291
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java ---
@@ -101,33 +100,44 @@ public boolean isGlobalSession(long
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205923249
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205922930
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -127,14 +127,11 @@
Long logSize =
Github user suyogmapara commented on the issue:
https://github.com/apache/zookeeper/pull/567
@maoling Thanks for the review, regarding concern around PreAllocSize,
thanks to ZOOKEEPER-2249, setting txnLogSizeLimit less than preAllocSize should
not cause any issue. I can add explicit
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205922455
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
---
@@ -280,6 +275,11 @@ public synchronized boolean addSession(long id,
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205920893
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -72,7 +72,7 @@
static final File BASETEST =
new
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205921489
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTracker.java ---
@@ -47,21 +47,20 @@
long createSession(int sessionTimeout);
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205920948
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumBase.java ---
@@ -53,32 +53,32 @@
protected int port3;
protected int port4;
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205921085
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
---
@@ -19,6 +19,8 @@
import
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205922234
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java ---
@@ -85,31 +85,43 @@ public boolean isGlobalSession(long
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205921331
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTracker.java ---
@@ -47,21 +47,20 @@
long createSession(int sessionTimeout);
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/496#discussion_r205904126
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
@@ -66,8 +67,8 @@ public SaslQuorumAuthLearner(boolean
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205903481
--- Diff: src/java/main/org/apache/zookeeper/metrics/Summary.java ---
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205902926
--- Diff: src/java/main/org/apache/zookeeper/metrics/Gauge.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205902898
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r205903511
--- Diff: src/java/main/org/apache/zookeeper/metrics/MetricsProvider.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/572#discussion_r205901936
--- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java ---
@@ -20,8 +20,35 @@
/**
* Exit code used to exit server
*/
Github user pravsingh commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/572#discussion_r205901511
--- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java ---
@@ -20,8 +20,35 @@
/**
* Exit code used to exit server
*/
Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205897728
--- Diff: src/java/test/org/apache/zookeeper/test/TxnLogSizeLimitTest.java
---
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560215#comment-16560215
]
Oded commented on ZOOKEEPER-3036:
-
We are running with kafka 1.1.0
> Unexpected exception in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560186#comment-16560186
]
Kevin Lu commented on ZOOKEEPER-3036:
-
[~o...@coralogix.com] yes multiple brokers think they are
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560168#comment-16560168
]
Andor Molnar commented on ZOOKEEPER-3100:
-
Got it. Sorry, I keep forgetting about this is
Github user cpoerschke commented on the issue:
https://github.com/apache/zookeeper/pull/47
Ah, oops, @ghost is indeed a ghost!
Hmm, so is it unclear then how or who this pull request could be closed by
then?
Except perhaps the customary "Closes #47" in a commit which
Github user cpoerschke commented on the issue:
https://github.com/apache/zookeeper/pull/47
@phunt looks like i don't have the necessary privileges to close this pull
request.
@ghost as creator of the pull request, would you have a moment perhaps to
close it? thank you.
---
Github user cpoerschke commented on the issue:
https://github.com/apache/zookeeper/pull/566
Thanks everyone for your feedback!
> ... are you ok with removing the extra words in the log message?
Hmm, ok, done. Should I update the pull request and
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2004/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 41.20 KB...]
[junit] Running
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/563
thank you @bothejjms !
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559837#comment-16559837
]
Rajini Sivaram commented on ZOOKEEPER-3100:
---
[~andorm] In the failing Kafka test, ZooKeeper
Github user bothejjms commented on the issue:
https://github.com/apache/zookeeper/pull/563
I have refactored the branches as suggested.
---
Github user bothejjms commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/563#discussion_r205778339
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1128,9 +1128,9 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559776#comment-16559776
]
Andor Molnar commented on ZOOKEEPER-3100:
-
[~rsivaram]
I've run a few tests with current 3.4
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/584#discussion_r205749086
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -478,7 +478,10 @@ public void createNode(final String path, byte data[],
List
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559635#comment-16559635
]
Hudson commented on ZOOKEEPER-3057:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #123 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559636#comment-16559636
]
Hudson commented on ZOOKEEPER-3067:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #123 (See
See https://builds.apache.org/job/ZooKeeper-trunk/123/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 144.25 KB...]
[junit] Tests run: 1, Failures: 0,
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/2/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 3.54 KB...]
at
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/565
Committed to master branch.
Thanks @jpeach !
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/565
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3067.
-
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 565
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/548
Committed to master branch only, because it conflicts with 3.5.
@mjeelanimsft Would you please create separate pull request for branch-3.5
and branch-3.4?
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/548
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/548
Jenkins is green and we got 2 approvals. Committing.
---
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/583
It's not a blocker for me, I agree it would be nice to have a unified
format, but that's pretty hard to achieve on an Apache I think :(
Anyway, that's why I wrote a "comment" review, not
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r205729889
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/UtilTest.java ---
@@ -0,0 +1,91 @@
+/**
--- End diff --
I had to make a
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r205729651
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -866,6 +866,9 @@ public void setServerCnxnFactory(ServerCnxnFactory
GitHub user lordofkey opened a pull request:
https://github.com/apache/zookeeper/pull/586
Zookeeper 3105:Character coding problem occur when create a node using
python3
when creating a node using python3, InvalidACLException occurs all the
time. it`s caused by imcompatible way of
Github user lordofkey closed the pull request at:
https://github.com/apache/zookeeper/pull/585
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559328#comment-16559328
]
Oded commented on ZOOKEEPER-3036:
-
Hi,
We did the same but the issue returned again. It happens to
66 matches
Mail list logo
