Github user suyogmapara commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r206338732
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for
Praveendra Singh created ZOOKEEPER-3107:
---
Summary: Coding standard and Checkstyle
Key: ZOOKEEPER-3107
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3107
Project: ZooKeeper
Issue
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/545
>> We could keep the original API and setting the secure field appropriate
to stay on the safe side, but that won't satisfy your suggestion.
I think we can do this. Later when we can break
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562446#comment-16562446
]
Hadoop QA commented on ZOOKEEPER-1621:
--
-1 overall. Here are the results of testing the latest
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1621
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3700/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-1621:
--
Labels: pull-request-available (was: )
> ZooKeeper does not recover from crash
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/439
@abhishekrai @hanm
Given that we closed #560 , is this pull request still relevant?
Maybe I'm missing something here and these are just similar issues and not
the same.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562430#comment-16562430
]
Andor Molnar commented on ZOOKEEPER-3082:
-
[~nixon] [~hanm]
Thanks for sorting this out. Do
Github user pravsingh commented on the issue:
https://github.com/apache/zookeeper/pull/572
agree with you guys. ð
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/572
@pravsingh @nkalmar I don't think we need to add unit tests to verify enum
values, it doesn't add too much value I believe. Unless we already have unit
tests like this in the codebase, but I
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm Trying to make the API consistent by keeping one setter and getter
for the property. It escalated a bunch of other changes which I think are good
improvements and made the code simpler:
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/572
@pravsingh , I changed the comments to javadoc comments. But after creating
the tests, it was kind of strange. I looked at other enum in ZK, we don't check
the values. I think we will see in a PR
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561968#comment-16561968
]
Benjamin Reed commented on ZOOKEEPER-3036:
--
can you give a bit more detail as to what
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3106:
--
Labels: pull-request-available (was: )
> Zookeeper client supports IPv6 address
GitHub user maoling opened a pull request:
https://github.com/apache/zookeeper/pull/587
ZOOKEEPER-3106: Zookeeper client supports IPv6 address and document the
"IPV6 feature"
The related UTs in the `ConnectStringParserTest` have all passed,I also
tested it in the real IPv6 ENV.
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r206120103
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -866,6 +866,9 @@ public void setServerCnxnFactory(ServerCnxnFactory
Github user anmolnar commented on the pull request:
https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29886282
Insecure. JMX and Jetty are the future for 3.5+
JMX is also questionable. Not sure if we could drop that too.
---
Github user maoling commented on the pull request:
https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29885683
@nkalmar
Thanks for your ACK. 4 letter words will be deprecated? why?
---
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1065/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 62.76 KB...]
[junit] Tests run: 1, Failures:
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/572#discussion_r206045238
--- Diff: src/java/main/org/apache/zookeeper/server/ExitCode.java ---
@@ -20,8 +20,35 @@
/**
* Exit code used to exit server
*/
Github user nkalmar commented on the pull request:
https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29880817
@maoling It has been intentionally removed from 3.6 and 3.5, as I was told
the 4 letter words is deprecated, and it will be
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maoling updated ZOOKEEPER-3106:
---
Description:
This issue is the follow-up work of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561475#comment-16561475
]
Hudson commented on ZOOKEEPER-3082:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #128 (See
23 matches
Mail list logo
