[GitHub] zookeeper issue #580: ZOOKEEPER-3098: Add additional server metrics

2018-07-31 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/580 @eolivelli @jtuple I think the best would be to join the efforts and work together to establish the new framework and implement these new metrics with a suitable library like dropwizard. At

[jira] [Commented] (ZOOKEEPER-3108) deprecated myid file and use a new property "server.id" in the zoo.cfg

2018-07-31 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564725#comment-16564725 ] Fangmin Lv commented on ZOOKEEPER-3108: --- I think this is a good idea, but it's better to keep

[GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...

2018-07-31 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/582 @eolivelli I'll take a look today. ---

[GitHub] zookeeper pull request #:

2018-07-31 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29915646 @anmolnar Sir, Could you plz tell me why the 4 letter words is insecure? ---

Re: ZK ACL question

2018-07-31 Thread Brian Nixon
Hi William, It's been a while since I've looked at this. You could double-check against how the kazoo client is handling encoding -> https://github.com/python-zk/kazoo/blob/master/kazoo/security.py#L61 . Does this help? -Brian On Wed, Jul 18, 2018 at 7:36 AM, William Jardine wrote: > Hey

Re: Jenkins jobs are not triggering

2018-07-31 Thread Patrick Hunt
I updated the jira issue. There were a couple recent updates to the job config (me and Michael) but nothing obvious. Patrick On Tue, Jul 31, 2018 at 3:15 AM Norbert Kalmar wrote: > Hi folks, > > Since yesterday, the Jenkins job on the PR's are not triggering. > I created a jira about it: >

[GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...

2018-07-31 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/582 @hanm @anmolnar do you have cycles for review? If this approach is good I can send the second part, about booting the provider in the server and providing some sample instrumentation ---

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-07-31 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/184 Rebased to resolve merge conflict. @hanm A gentle nudge that we're waiting for your review in this important patch. ---

ZooKeeper_branch34_openjdk7 - Build # 2009 - Failure

2018-07-31 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2009/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 41.22 KB...] [junit] Running

Re:Jenkins jobs are not triggering

2018-07-31 Thread 岭秀
The Mr Jenkins went on vacation? maoling Beijing,China - 原始邮件 - 发件人:Norbert Kalmar 收件人:dev@zookeeper.apache.org 主题:Jenkins jobs are not triggering 日期:2018年07月31日 18点16分 Hi folks, Since yesterday, the Jenkins job on the PR's are not triggering. I

[jira] [Commented] (ZOOKEEPER-3107) Coding standard and Checkstyle

2018-07-31 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563613#comment-16563613 ] maoling commented on ZOOKEEPER-3107: [~psinghiitr] yes.when we have moved from Ant to Maven.we

[jira] [Created] (ZOOKEEPER-3108) deprecated myid file and use a new property "server.id" in the zoo.cfg

2018-07-31 Thread maoling (JIRA)
maoling created ZOOKEEPER-3108: -- Summary: deprecated myid file and use a new property "server.id" in the zoo.cfg Key: ZOOKEEPER-3108 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3108 Project:

Failed: ZOOKEEPER- PreCommit Build #2006

2018-07-31 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2006/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.90 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #2005

2018-07-31 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2005/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 287 B...] Building remotely on H0

Jenkins jobs are not triggering

2018-07-31 Thread Norbert Kalmar
Hi folks, Since yesterday, the Jenkins job on the PR's are not triggering. I created a jira about it: https://issues.apache.org/jira/browse/INFRA-16844 (Hopefully it's not a duplicate, I didn't found any other jira about this.) Regards, Norbert

[GitHub] zookeeper issue #574: ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move con...

2018-07-31 Thread nkalmar
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/574 @anmolnar I did an amend commit, it doesn't seem to trigger the build. I also did a normal commit yesterday on my other PR, which also didn't trigger the build. Strange. Maybe I'll closing and

[GitHub] zookeeper issue #574: ZOOKEEPER-3030 - MAVEN MIGRATION - Step 1.3 - move con...

2018-07-31 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/574 @nkalmar I think this is good to go as it. Would you please trigger a build, because it looks hasn't been started for the last commit. ---

[GitHub] zookeeper issue #545: ZOOKEEPER-2261 When only secureClientPort is configure...

2018-07-31 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/545 No worries, let's go down this road, I think we're on the right track and this is good refactoring. I'll make the necessary changes today. ---

[GitHub] zookeeper issue #447: [ZOOKEEPER-2926] Fix potential data consistency issue ...

2018-07-31 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/447 Thanks @hanm, I've updated the diff based on your comments and rebased onto latest master code. ---

[GitHub] zookeeper issue #583: [ZOOKEEPER-3104] Fix data inconsistency due to NEWLEAD...

2018-07-31 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/583 Thanks @breed, the conflict is resolved. ---