Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207705040
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207704611
--- Diff: src/java/main/org/apache/zookeeper/metrics/Gauge.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207704605
--- Diff: src/java/main/org/apache/zookeeper/metrics/MetricsContext.java ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/580
@jtuple in my opinion it is better to allow all of changes coming from
Facebook to be merged in as soon as possible.
Having only one common codebase is necessary in order to work together.