Failed: ZOOKEEPER- PreCommit Build #2041

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2041/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.75 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3071) Add a config parameter to control transaction log size

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575685#comment-16575685 ] Hadoop QA commented on ZOOKEEPER-3071: -- -1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...

Github user suyogmapara commented on the issue: https://github.com/apache/zookeeper/pull/567 @anmolnar I updated the documentation, please let me know if it looks alright ---

ZooKeeper_branch34_jdk8 - Build # 1492 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1492/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.47 KB...] [junit] Tests run: 1, Failures:

[GitHub] zookeeper issue #593: [ZOOKEEPER-3111] Add socket buffer size option to tune...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/593 @lvfangmin Cool, thanks for the good addition. Please write some unit tests for the `SocketUtil` class. ---

[GitHub] zookeeper issue #594: [ZOOKEEPER-3116] Make the DataTree.approximateDataSize...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/594 @lvfangmin I this is a very good improvement. Do you think that existing unit tests cover this functionality or it might be beneficial to add some? ---

[GitHub] zookeeper pull request #580: ZOOKEEPER-3098: Add additional server metrics

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/580#discussion_r209038790 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -127,36 +129,45 @@ public String toString(){ sb.append("Mode: "

[GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/582 Sorry @eolivelli I really don't want to block this patch, but I'd like to get a better understanding on the roles of the classes/interfaces here. - What's the original concept that you're

[GitHub] zookeeper issue #582: ZOOKEEPER-3103 Pluggable metrics system for ZooKeeper ...

Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/582 Shall we commit this patch ? So we can make little steps forward. This change does not impact how zk works, it is safe ---

[jira] [Commented] (ZOOKEEPER-3082) Fix server snapshot behavior when out of disk space

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574818#comment-16574818 ] Andor Molnar commented on ZOOKEEPER-3082: - Thanks [~nixon] > Fix server snapshot behavior

[GitHub] zookeeper issue #590: [ZOOKEEPER-1177] Add the memory optimized watch manage...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/590 This is going to be a huge improvement for Accumulo for example that is a heavy user of watchers. I'm going to allocate some capacity to review these new patches. ---

[GitHub] zookeeper pull request #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAd...

Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/592#discussion_r208814126 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java --- @@ -280,10 +281,14 @@ void registerAndConnect(SocketChannel sock,