[GitHub] zookeeper issue #611: ZOOKEEPER-3131

2018-08-29 Thread wangchaod
Github user wangchaod commented on the issue: https://github.com/apache/zookeeper/pull/611 @enixon In my running environment, the temporarily empty state of its watch set will not pass soon. So then, the empty watcher increases to more than 10 thousand, and the OutOfMemoryError

[jira] [Created] (ZOOKEEPER-3135) ClientCnxnSocket#updateLastSendAndHeard() method update lastSend、lastHeard has some problem

2018-08-29 Thread yangkun (JIRA)
yangkun created ZOOKEEPER-3135: -- Summary: ClientCnxnSocket#updateLastSendAndHeard() method update lastSend、lastHeard has some problem Key: ZOOKEEPER-3135 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3135

[jira] [Commented] (ZOOKEEPER-3108) deprecated myid file and use a new property "server.id" in the zoo.cfg

2018-08-29 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596893#comment-16596893 ] Enrico Olivelli commented on ZOOKEEPER-3108: I would add a validation that if you have

[GitHub] zookeeper issue #611: ZOOKEEPER-3131

2018-08-29 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/611 I see. It depends on what you are optimizing. The Watcher will be removed from watch2Paths when the ServerCnxn for it is closed. Keeping a set in the map for it strikes me as an optimization based

[jira] [Updated] (ZOOKEEPER-3131) org.apache.zookeeper.server.WatchManager resource leak

2018-08-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3131: -- Labels: pull-request-available (was: ) > org.apache.zookeeper.server.WatchManager

[GitHub] zookeeper pull request #611: ZOOKEEPER-3131

2018-08-29 Thread wangchaod
GitHub user wangchaod opened a pull request: https://github.com/apache/zookeeper/pull/611 ZOOKEEPER-3131 org.apache.zookeeper.server.WatchManager resource leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/wangchaod/zookeeper

[jira] [Created] (ZOOKEEPER-3134) NIOServerCnxnFactory#run() method should remove synchronized (this)

2018-08-29 Thread yangkun (JIRA)
yangkun created ZOOKEEPER-3134: -- Summary: NIOServerCnxnFactory#run() method should remove synchronized (this) Key: ZOOKEEPER-3134 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3134 Project:

[jira] [Commented] (ZOOKEEPER-3108) deprecated myid file and use a new property "server.id" in the zoo.cfg

2018-08-29 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596205#comment-16596205 ] maoling commented on ZOOKEEPER-3108: [~hanm] IMO, put the myid in the *dataDir* is not very good

[jira] [Commented] (ZOOKEEPER-3126) Documentation: Overview page has missing content

2018-08-29 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596071#comment-16596071 ] maoling commented on ZOOKEEPER-3126: [~pritish.kapoor] Yes,you're right.the* zookeeperOver.html*

[jira] [Commented] (ZOOKEEPER-3129) Improve ZK Client resiliency by throwing a jute.maxbuffer size exception before sending a request to server

2018-08-29 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596024#comment-16596024 ] Karan Mehta commented on ZOOKEEPER-3129: I can put up a patch if people are interested here.

Re: Jute max buffer size related question

2018-08-29 Thread Karan Mehta
Got it. That makes sense. Thanks! Let me know your thoughts on https://issues.apache.org/jira/browse/ZOOKEEPER-3129 Karan On Fri, Aug 24, 2018 at 6:10 PM Benjamin Reed wrote: > we stop reading the socket once we hit max buffer size so we don't > overflow memory. it was put in when a buggy