[
https://issues.apache.org/jira/browse/ZOOKEEPER-3123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599613#comment-16599613
]
Hadoop QA commented on ZOOKEEPER-3123:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599609#comment-16599609
]
Hadoop QA commented on ZOOKEEPER-3136:
--
+1 overall. GitHub Pull Request Build
+1
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/601
Seems there is an error on CI related to the patch.
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/614
@maoling I have addressed your comment
---
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r214507592
--- Diff: src/java/test/org/apache/zookeeper/server/SocketUtilTest.java ---
@@ -37,7 +37,7 @@ public void testSetSocketBufferSize() throws Exception {
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r214507553
--- Diff: src/java/main/org/apache/zookeeper/server/SocketUtil.java ---
@@ -13,18 +31,18 @@
--- End diff --
some useless import?
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/614#discussion_r214507696
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -287,6 +288,9 @@ public static boolean waitForServerUp(String hp, long
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/614#discussion_r214506993
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -287,6 +288,9 @@ public static boolean waitForServerUp(String hp, long
timeout,
