[
https://issues.apache.org/jira/browse/ZOOKEEPER-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605227#comment-16605227
]
Hadoop QA commented on ZOOKEEPER-3106:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605072#comment-16605072
]
Hudson commented on ZOOKEEPER-3090:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #178 (See
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/580
And yes like others commented, please rebase and resolve conflicts, and
reply to previous unattended comments. My previous comments need address are:
* Existing unit test failures and one
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/580
One question about gathering metrics using this system: let's say I have a
use case where I want to gather the number of requests processed by
FinalRequestProcessor for each request type (e.g. Ping,
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/580
We at Twitter manage large ZK clusters and we also have our own internal
metrics system (you can't really operate things like ZK without metrics at
large scale.). Our design is similar like this in
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/612
Close and reopen the pull request could also trigger a build, which might
be more convenient than amending the commit.
For committers or those who have admin access to apache JIRA, just find
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/573
---
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/615
@anmolnar , you can find a trial integration of the chop function with
TxnLogToolkit at
https://github.com/enixon/zookeeper/commit/b71ce04f70873f590c6cf5c24a691a1f1af82f48
. It's not the cleanest
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/573
I manually triggered a build and it's green now
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2122/
Github integration still broken for this PR for some reasons. This
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/615
Integrate into TxnLogToolkit is a good idea. I did not mention it as I
thought that might require a separate JIRA, because LogFormatter can also be
integrated (it's the least powerful tool of the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605042#comment-16605042
]
Hadoop QA commented on ZOOKEEPER-3137:
--
-1 overall. GitHub Pull Request Build
+1
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/615
@hanm, I've made your recommended changes with the exception noted in my
comment.
@anmolnar , looking at TxnLogToolkit now - I think this should be easy to
integrate :)
---
Github user enixon commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/615#discussion_r215446231
--- Diff: src/java/main/org/apache/zookeeper/server/util/LogChopper.java ---
@@ -0,0 +1,152 @@
+/**
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605011#comment-16605011
]
Hudson commented on ZOOKEEPER-3127:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #177 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605005#comment-16605005
]
Karan Mehta commented on ZOOKEEPER-3129:
Thoughts anyone?
> Improve ZK Client resiliency by
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/612
Is there any easy way to trigger the build? It's a bit painful to doing
trigger this by adding empty commit.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv resolved ZOOKEEPER-3111.
---
Resolution: Not A Problem
> Add socket buffer size option to tune the TCP throughput
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604962#comment-16604962
]
Fangmin Lv commented on ZOOKEEPER-3111:
---
Commented in the PR, also mention it here for easier
Github user lvfangmin closed the pull request at:
https://github.com/apache/zookeeper/pull/593
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/606
committed to master @lvfangmin @breed
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3127.
Resolution: Fixed
Fix Version/s: (was: 3.4.14)
(was:
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/606
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/590
Thanks @nkalmar for the suggestion of bench project position, I was
following the same directory as the src/java/systest for now, do you think we
can move them together later? I'm not against
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/593
@maoling, sorry for the lately reply, I forgot to reply this PR.
We've done some benchmark when we added this code a year ago, I was trying
to find some benchmark data at that point,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604742#comment-16604742
]
Hudson commented on ZOOKEEPER-2913:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #176 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grzegorz Grzybek updated ZOOKEEPER-3138:
Description:
I'm in the process of reconfiguring the ensemble to use mutual
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grzegorz Grzybek updated ZOOKEEPER-3138:
Description:
I'm in the process of reconfiguring the ensemble to use mutual
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grzegorz Grzybek updated ZOOKEEPER-3138:
Description:
I'm in the process of reconfiguring the ensemble to use mutual
Grzegorz Grzybek created ZOOKEEPER-3138:
---
Summary: Potential race condition with Quorum Peer mutual
authentication via SASL
Key: ZOOKEEPER-3138
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3138
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/587
@maoling please rebase the patch
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/573
@a470577391 Mr Jenkins has come back.could you plz close and reopen this PR
to kick off he?
ping @anmolnar
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/608
> Do you mind opening a PR to fix the other test?
@anmolnar
other same tests should analyse on the specific circumstances.I will follow
up and hope others' work about this issue.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604492#comment-16604492
]
Hadoop QA commented on ZOOKEEPER-1011:
--
-1 overall. GitHub Pull Request Build
+1
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/593
@lvfangmin
it will be a very useful option for tunning the network perfermance between
leader and follower.
but you should give us some test evidence(smirk).
can we get the inclusion:
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/593
> What do you mean by 'do regression' exactly?
@anmolnar like this(grin):
`int index = 0;
while (true) {
try {
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/608
Committed. 3.5 and master branches. Thanks @maoling .
Do you mind opening a PR to fix the other test?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-2913.
-
Resolution: Fixed
Fix Version/s: 3.5.5
3.6.0
Issue
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/608
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-1011:
--
Labels: pull-request-available (was: )
> fix Java Barrier Documentation example's
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/608
@anmolnar Take it easy(grin).
> Do you think other flaky test could be impacted by the same issue?
I dig into another issue[
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/611
@enixon I think it leaks the map anyway, because when the new Watcher is
added, new Watcher instance gets created which will be added to Map anyway and
the empty one remains forever.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/593
@maoling I've run the test a few times on Mac and CentOs, but it doesn't
seem to be flaky for me.
What do you mean by 'do regression' exactly?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/608
@maoling
+1 for the solution anyway. I tend to commit this anyway.
Do you think other flaky test could be impacted by the same issue?
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/608
@anmolnar
This flaky test had happend many times found by ZOOKEEPER-2913 and
ZOOKEEPER-3040 reported by Patrick Hunt
The build failed report url about it is
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/608
Good job @maoling .
However I can't see this test in the latest flaky test report:
https://builds.apache.org/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html
Is
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/607
Basically my biggest concern is that this patch shouldn't go into 3.4,
because it's not critical.
3.5 is just around the corner and improvements like this will encourage
people to upgrade
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/607
Thanks for the contribution @lavacat .
Please take a look at my comments in the Jira.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604232#comment-16604232
]
Andor Molnar commented on ZOOKEEPER-2990:
-
[~bkanivets]
What are the target versions of this
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/590
@lvfangmin Docs for the new caching parameter `zookeeper.bitHashCacheSize`?
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/590#discussion_r215183702
--- Diff:
src/java/main/org/apache/zookeeper/server/watch/WatchManagerOptimized.java ---
@@ -0,0 +1,355 @@
+/**
+ * Licensed to the Apache
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/590#discussion_r215180602
--- Diff: src/java/main/org/apache/zookeeper/server/watch/WatchManager.java
---
@@ -46,15 +48,26 @@
private final Map> watch2Paths =
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/615
@enixon Your patch looks good, this is going to be a useful tool for
ZooKeeper.
Have you considered adding this functionality to `TxnLogToolkit` (a tool
developed by me :), instead of
52 matches
Mail list logo
