[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-25 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/639 a problem is when the network get disconnect, the client will enter into two state, one is ZOO_EXPIRED_SESSION_STATE, the other is ZOO_CONNECTING_STATE, the problem is the client didn't

Re: New precommit job 'retest this please' trick

2018-09-25 Thread Fangmin Lv
This makes things much easier! Thanks a lot for setting this up! Fangmin On Tue, Sep 25, 2018 at 10:37 AM Brian Nixon wrote: > Excellent! > > > On Mon, Sep 24, 2018 at 11:06 AM Andor Molnár wrote: > > > Awesome! > > > > > > > > On 09/24/2018 06:27 PM, Michael Han wrote: > > >>> How the new

[GitHub] zookeeper issue #642: ZOOKEEPER-3151: test Jenkins. Don't merge.

2018-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/642 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2263/ ---

Failed: ZOOKEEPER- PreCommit Build #2263

2018-09-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2263/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.19 MB...] [exec]

[GitHub] zookeeper issue #642: ZOOKEEPER-3151: test Jenkins. Don't merge.

2018-09-25 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/642 RETest this PleasePlease ---

[GitHub] zookeeper issue #642: ZOOKEEPER-3151: test Jenkins. Don't merge.

2018-09-25 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/642 test this ---

[GitHub] zookeeper issue #642: ZOOKEEPER-3151: test Jenkins. Don't merge.

2018-09-25 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/642 Please ---

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-25 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/184 @anmolnar sure, will sign this off before next monday. ---

[GitHub] zookeeper pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improve...

2018-09-25 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/629#discussion_r220404846 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -35,7 +35,7 @@ private long totalLatency = 0; private long

[GitHub] zookeeper pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improve...

2018-09-25 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/629#discussion_r220403065 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -53,10 +54,13 @@ public ServerStats(Provider provider) { synchronized

ZooKeeper-trunk - Build # 205 - Still Failing

2018-09-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/205/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 146.68 KB...] [junit] Tests run: 1, Failures: 0,

[GitHub] zookeeper pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improve...

2018-09-25 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/629#discussion_r220382358 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -53,10 +54,13 @@ public ServerStats(Provider provider) {

[GitHub] zookeeper pull request #629: ZOOKEEPER-2641:AvgRequestLatency metric improve...

2018-09-25 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/629#discussion_r220382505 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -35,7 +35,7 @@ private long totalLatency = 0; private long

Re: Java version (Oracle - OpenJDK) support

2018-09-25 Thread Andor Molnar
Hi, branch34_java11 is blue now: https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch34_java11/ Looks like we have Java 11 support on 3.4 now. Regards, Andor On Fri, Sep 21, 2018 at 6:20 PM, Norbert Kalmar < nkal...@cloudera.com.invalid> wrote: > Just throwing in a nice

ZooKeeper-trunk-windows-cmake - Build # 2950 - Still Failing

2018-09-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2950/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.79 KB...] [ivy:retrieve] confs: [javacc]

ZooKeeper_branch34_openjdk7 - Build # 2067 - Failure

2018-09-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2067/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 44.43 KB...] [junit] Running

Re: New precommit job 'retest this please' trick

2018-09-25 Thread Brian Nixon
Excellent! On Mon, Sep 24, 2018 at 11:06 AM Andor Molnár wrote: > Awesome! > > > > On 09/24/2018 06:27 PM, Michael Han wrote: > >>> How the new process any different from that? > > Jenkins job triggered by "Rebuild" button can't write back the job result > > to github, leading to a yellow

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2262/ ---

Failed: ZOOKEEPER- PreCommit Build #2262

2018-09-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2262/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.88 MB...] [exec]

ZooKeeper_branch34_openjdk8 - Build # 67 - Still Failing

2018-09-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/67/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by an SCM change Started by an SCM change [EnvInject]

[GitHub] zookeeper pull request #626: ZOOKEEPER-3148 Add Kerberos tests for modern JD...

2018-09-25 Thread eolivelli
Github user eolivelli closed the pull request at: https://github.com/apache/zookeeper/pull/626 ---

[GitHub] zookeeper pull request #639: ZOOKEEPER-2122: add openssl to zookeeper c clie...

2018-09-25 Thread roodkcab
Github user roodkcab commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/639#discussion_r220168781 --- Diff: zookeeper-client/zookeeper-client-c/src/zookeeper.c --- @@ -2213,6 +2259,72 @@ static socket_t zookeeper_connect(zhandle_t *zh,

Success: ZOOKEEPER- PreCommit Build #2261

2018-09-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2261/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.95 MB...] [exec] +1

[GitHub] zookeeper issue #626: ZOOKEEPER-3148 Add Kerberos tests for modern JDKs

2018-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/626 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2261/ ---

Success: ZOOKEEPER- PreCommit Build #2260

2018-09-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2260/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.82 MB...] [exec] +1

[GitHub] zookeeper issue #540: Branch 3.4

2018-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/540 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2260/ ---

[GitHub] zookeeper pull request #639: ZOOKEEPER-2122: add openssl to zookeeper c clie...

2018-09-25 Thread roodkcab
Github user roodkcab commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/639#discussion_r220159265 --- Diff: zookeeper-client/zookeeper-client-c/CMakeLists.txt --- @@ -56,7 +56,7 @@ option(WANT_CPPUNIT "Enables CppUnit and tests"

[GitHub] zookeeper issue #642: ZOOKEEPER-3151: test Jenkins. Don't merge.

2018-09-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/642 Please close this PR (don't) ---

[GitHub] zookeeper issue #642: ZOOKEEPER-3151: test Jenkins. Don't merge.

2018-09-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/642 please ---

[GitHub] zookeeper issue #626: ZOOKEEPER-3148 Add Kerberos tests for modern JDKs

2018-09-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/626 Committed to 3.4 @eolivelli Please close this PR. ---

[jira] [Resolved] (ZOOKEEPER-3148) Fix Kerberos tests on branch 3.4 and JDK11

2018-09-25 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3148. - Resolution: Fixed Fix Version/s: 3.4.14 Issue resolved by pull request 626

Success: ZOOKEEPER- PreCommit Build #2259

2018-09-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2259/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.52 MB...] [exec] +1

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/184 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2259/ ---

ZooKeeper_branch34_openjdk8 - Build # 66 - Failure

2018-09-25 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/66/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 32.19 KB...] [junit] Tests run: 4, Failures:

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/184 @eolivelli Looks like I triggered the build with my latest comment. Maybe my comment to @hanm :) ---

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/184 @ivmaykov *portUnification* Let's just disable the feature completely in this patch: don't parse the config option to be on the safe side. Rolling upgrade will be supported once we

[GitHub] zookeeper pull request #639: ZOOKEEPER-2122: add openssl to zookeeper c clie...

2018-09-25 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/639#discussion_r220134951 --- Diff: zookeeper-client/zookeeper-client-c/CMakeLists.txt --- @@ -56,7 +56,7 @@ option(WANT_CPPUNIT "Enables CppUnit and tests"

[GitHub] zookeeper pull request #639: ZOOKEEPER-2122: add openssl to zookeeper c clie...

2018-09-25 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/639#discussion_r220136616 --- Diff: zookeeper-client/zookeeper-client-c/src/zookeeper.c --- @@ -2213,6 +2259,72 @@ static socket_t zookeeper_connect(zhandle_t *zh,

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-25 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/639 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2258/ ---

Failed: ZOOKEEPER- PreCommit Build #2258

2018-09-25 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2258/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.79 MB...] [exec]

Build failed in Jenkins: ZooKeeper-trunk-owasp #121

2018-09-25 Thread Apache Jenkins Server
See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H33 (ubuntu xenial) in workspace

[GitHub] zookeeper issue #639: ZOOKEEPER-2122: add openssl to zookeeper c client to s...

2018-09-25 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/639 retest this please ---