[GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...

2018-11-18 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/689#discussion_r234504039 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java --- @@ -102,24 +104,24 @@ public void addDeadWatcher(int

[GitHub] zookeeper issue #703: [ZOOKEEPER-1818] Correctly handle potential inconsiste...

2018-11-18 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/703 @anmolnar this is the fix for the DONTCARE on trunk, please take a look, I'll port it to 3.5 when it's being reviewed and merged. ---

[GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...

2018-11-18 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/689#discussion_r234494972 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java --- @@ -102,24 +104,24 @@ public void

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-18 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 @eolivelli Yep, I agree with you. ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-18 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/294 I would go for a system property ---

[GitHub] zookeeper pull request #:

2018-11-18 Thread asdf2014
Github user asdf2014 commented on the pull request: https://github.com/apache/zookeeper/commit/82da83a7176bbdd73dedb6fc3d96dac706cefad3#commitcomment-31341678 In zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java: In

[GitHub] zookeeper pull request #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBean...

2018-11-18 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/294#discussion_r234446570 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java --- @@ -71,7 +71,7 @@ public static void registerLog4jMBeans() throws

[GitHub] zookeeper pull request #705: ZOOKEEPER-3167:add an API to get total count of...

2018-11-18 Thread TyqITstudent
Github user TyqITstudent closed the pull request at: https://github.com/apache/zookeeper/pull/705 ---

[GitHub] zookeeper pull request #705: ZOOKEEPER-3167:add an API to get total count of...

2018-11-18 Thread TyqITstudent
GitHub user TyqITstudent opened a pull request: https://github.com/apache/zookeeper/pull/705 ZOOKEEPER-3167:add an API to get total count of recursive sub nodes of one node 1. In production environment, there will be always a situation that there are a lot of recursive sub nodes

[GitHub] zookeeper pull request #704: ZOOKEEPER-3167:add an API to get total count of...

2018-11-18 Thread TyqITstudent
Github user TyqITstudent closed the pull request at: https://github.com/apache/zookeeper/pull/704 ---

[GitHub] zookeeper pull request #704: ZOOKEEPER-3167:add an API to get total count of...

2018-11-18 Thread TyqITstudent
GitHub user TyqITstudent opened a pull request: https://github.com/apache/zookeeper/pull/704 ZOOKEEPER-3167:add an API to get total count of recursive sub nodes of one node 1. In production environment, there will be always a situation that there are a lot of recursive sub nodes

[GitHub] zookeeper pull request #686: Zookeeper 3167

2018-11-18 Thread TyqITstudent
Github user TyqITstudent closed the pull request at: https://github.com/apache/zookeeper/pull/686 ---

[GitHub] zookeeper pull request #688: reduce session revalidation time after zxid rol...

2018-11-18 Thread TyqITstudent
Github user TyqITstudent closed the pull request at: https://github.com/apache/zookeeper/pull/688 ---

[GitHub] zookeeper pull request #687: Zookeeper 3169

2018-11-18 Thread TyqITstudent
Github user TyqITstudent closed the pull request at: https://github.com/apache/zookeeper/pull/687 ---