ZooKeeper_branch34_jdk7 - Build # 2129 - Failure

2018-11-20 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/2129/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 42.96 KB...] [junit] Running

[GitHub] zookeeper pull request #710: ZOOKEEPER-3195: TLS - disable client-initiated ...

2018-11-20 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/710#discussion_r235223996 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -60,6 +60,12 @@ public abstract class X509Util {

[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...

2018-11-20 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/700#discussion_r235218313 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -209,6 +209,8 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693936#comment-16693936 ] Michael Han commented on ZOOKEEPER-2778: I have to refresh my memory on this issue, but now

ZooKeeper-trunk - Build # 275 - Failure

2018-11-20 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/275/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 176.82 KB...] [junit] Running

[GitHub] zookeeper pull request #710: ZOOKEEPER-3195: TLS - disable client-initiated ...

2018-11-20 Thread ivmaykov
GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/710 ZOOKEEPER-3195: TLS - disable client-initiated renegotiation Summary: client-initiated renegotiation is insecure and is vulnerable to MITM attacks. Unfortunately, the feature is enabled

[GitHub] zookeeper pull request #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug...

2018-11-20 Thread ivmaykov
Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/709 ---

[GitHub] zookeeper pull request #710: ZOOKEEPER-3195: TLS - disable client-initiated ...

2018-11-20 Thread ivmaykov
Github user ivmaykov closed the pull request at: https://github.com/apache/zookeeper/pull/710 ---

[GitHub] zookeeper pull request #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug...

2018-11-20 Thread ivmaykov
GitHub user ivmaykov reopened a pull request: https://github.com/apache/zookeeper/pull/709 ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug in ZKTrustManager Fix an obvious copy/paste bug. Tested by making sure ZKTrustManagerTest still passes. You can merge this pull request into a

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael K. Edwards (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693898#comment-16693898 ] Michael K. Edwards commented on ZOOKEEPER-2778: --- >From what I'm seeing, it would be a

[jira] [Comment Edited] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael K. Edwards (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693898#comment-16693898 ] Michael K. Edwards edited comment on ZOOKEEPER-2778 at 11/20/18 11:44 PM:

[jira] [Comment Edited] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael K. Edwards (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693898#comment-16693898 ] Michael K. Edwards edited comment on ZOOKEEPER-2778 at 11/20/18 11:41 PM:

[jira] [Updated] (ZOOKEEPER-3195) TLS - disable client-initiated renegotiation

2018-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3195: -- Labels: pull-request-available (was: ) > TLS - disable client-initiated

[GitHub] zookeeper pull request #710: ZOOKEEPER-3195: TLS - disable client-initiated ...

2018-11-20 Thread ivmaykov
GitHub user ivmaykov opened a pull request: https://github.com/apache/zookeeper/pull/710 ZOOKEEPER-3195: TLS - disable client-initiated renegotiation Summary: client-initiated renegotiation is insecure and is vulnerable to MITM attacks. Unfortunately, the feature is enabled in

[jira] [Created] (ZOOKEEPER-3195) TLS - disable client-initiated renegotiation

2018-11-20 Thread Ilya Maykov (JIRA)
Ilya Maykov created ZOOKEEPER-3195: -- Summary: TLS - disable client-initiated renegotiation Key: ZOOKEEPER-3195 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3195 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager

2018-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3194: -- Labels: pull-request-available (was: ) > Quorum TLS - fix copy/paste bug in

[GitHub] zookeeper pull request #709: ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug...

2018-11-20 Thread ivmaykov
GitHub user ivmaykov opened a pull request: https://github.com/apache/zookeeper/pull/709 ZOOKEEPER-3194: Quorum TLS - fix copy/paste bug in ZKTrustManager Fix an obvious copy/paste bug. Tested by making sure ZKTrustManagerTest still passes. You can merge this pull request into a

[jira] [Created] (ZOOKEEPER-3194) Quorum TLS - fix copy/paste bug in ZKTrustManager

2018-11-20 Thread Ilya Maykov (JIRA)
Ilya Maykov created ZOOKEEPER-3194: -- Summary: Quorum TLS - fix copy/paste bug in ZKTrustManager Key: ZOOKEEPER-3194 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3194 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael K. Edwards (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693530#comment-16693530 ] Michael K. Edwards commented on ZOOKEEPER-2778: --- Is there a need to add a reader/writer

[GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses

2018-11-20 Thread mkedwards
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/707 The deadlock, as I understand it, comes from an attempt to take `QV_LOCK` in order to access `myElectionAddress` in thread A, while holding the lock on the `QuorumCnxManager` object; meanwhile,

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-20 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/679 @anmolnar the benefit of the current DOS tests is to verify that certain actions on a UnifiedSocket (getting input stream, setting socket options, etc) do not trigger the blocking read for TLS /

[GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses

2018-11-20 Thread mkedwards
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/707 There appear to be test failures in LeaderBeanTest: ``` [exec] [junit] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0.619 sec, Thread: 8, Class:

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

2018-11-20 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/679#discussion_r235070776 --- Diff: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java --- @@ -17,156 +17,644 @@ */

[GitHub] zookeeper pull request #673: [ZOOKEEPER-3177] Refactor request throttle logi...

2018-11-20 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/673#discussion_r235060561 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -86,10 +86,16 @@ public class ZooKeeperServer

[jira] [Updated] (ZOOKEEPER-3029) Create pom.xml for jute and server

2018-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3029: -- Labels: pull-request-available (was: ) > Create pom.xml for jute and server >

[GitHub] zookeeper pull request #708: WIP - ZOOKEEPER-3029 - add pom.xml for jute, cl...

2018-11-20 Thread nkalmar
GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/708 WIP - ZOOKEEPER-3029 - add pom.xml for jute, client and server Work In Progress Creating the maven build for zookeeper-server, zookeeper-jute and zookeeper-client (which only contains C

[jira] [Updated] (ZOOKEEPER-3164) Backport ZOOKEEPER-3057 to branch3.5

2018-11-20 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3164: --- Summary: Backport ZOOKEEPER-3057 to branch3.5 (was: Backport ZOOKEEPER-3057 to branch3.4) >

[jira] [Assigned] (ZOOKEEPER-3164) Backport ZOOKEEPER-3057 to branch3.4

2018-11-20 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling reassigned ZOOKEEPER-3164: -- Assignee: (was: maoling) > Backport ZOOKEEPER-3057 to branch3.4 >

[jira] [Updated] (ZOOKEEPER-3164) Backport ZOOKEEPER-3057 to branch3.4

2018-11-20 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3164: --- Issue Type: Improvement (was: Bug) > Backport ZOOKEEPER-3057 to branch3.4 >

[jira] [Updated] (ZOOKEEPER-3164) Backport ZOOKEEPER-3057 to branch3.4

2018-11-20 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3164: --- Priority: Minor (was: Major) > Backport ZOOKEEPER-3057 to branch3.4 >

[jira] [Assigned] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling reassigned ZOOKEEPER-2778: -- Assignee: (was: maoling) > Potential server deadlock between follower sync with

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693304#comment-16693304 ] maoling commented on ZOOKEEPER-2778: [~mkedwards] I take a quick look at your patch. the solution

[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...

2018-11-20 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/700#discussion_r235016741 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -209,6 +209,8 @@ public void run() {

[GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...

2018-11-20 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/700#discussion_r235013286 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java --- @@ -209,6 +209,8 @@ public void run() {

[jira] [Comment Edited] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael K. Edwards (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693231#comment-16693231 ] Michael K. Edwards edited comment on ZOOKEEPER-2778 at 11/20/18 1:35 PM:

[GitHub] zookeeper pull request #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addres...

2018-11-20 Thread mkedwards
GitHub user mkedwards opened a pull request: https://github.com/apache/zookeeper/pull/707 [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses [ZOOKEEPER-2778] QuorumPeer: encapsulate quorum/election/client addresses in an AddressTuple held through an AtomicReference You can merge

ZooKeeper_branch35_jdk8 - Build # 1201 - Failure

2018-11-20 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1201/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.97 KB...] [junit] Tests run: 1, Failures:

[jira] [Comment Edited] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael K. Edwards (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693231#comment-16693231 ] Michael K. Edwards edited comment on ZOOKEEPER-2778 at 11/20/18 1:30 PM:

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael K. Edwards (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693231#comment-16693231 ] Michael K. Edwards commented on ZOOKEEPER-2778: --- May I suggest a different approach? 

[GitHub] zookeeper pull request #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBean...

2018-11-20 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/294#discussion_r234997204 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java --- @@ -69,9 +69,13 @@ public static void registerLog4jMBeans()

[GitHub] zookeeper pull request #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBean...

2018-11-20 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/294#discussion_r234984710 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java --- @@ -69,9 +69,13 @@ public static void registerLog4jMBeans()

[GitHub] zookeeper pull request #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBean...

2018-11-20 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/294#discussion_r234959406 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java --- @@ -69,9 +69,13 @@ public static void registerLog4jMBeans()

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-20 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 @eolivelli Thanks for your comment. I will describe this variable in `zookeeperJMX.md`. ---