[
https://issues.apache.org/jira/browse/ZOOKEEPER-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3207:
--
Labels: pull-request-available (was: )
> WatchManager being copied over twice
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3207:
--
Summary: Watch related code being copied over twice when doing maven
migration (was:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3207:
--
Description: File like WatchManager.java and WatchesPathReport.java exist
in both
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/729
[ZOOKEEPER-3207] Removing the unexpected WatchManager.java introduced by
mistake during maven migration
You can merge this pull request into a Git repository by running:
$ git pull
Fangmin Lv created ZOOKEEPER-3207:
-
Summary: WatchManager being copied over twice when doing maven
migration
Key: ZOOKEEPER-3207
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3207
Project:
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238787735
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DumbWatcher.java ---
@@ -69,7 +69,7 @@ public void sendCloseSession() { }
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238786172
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -151,12 +148,17 @@ void sendBufferSync(ByteBuffer bb) {
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238794022
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238788593
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238788174
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -235,10 +237,12 @@ void handleWrite(SelectionKey k)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238790553
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238789004
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
@hanm is the latest change looking good to you?
---
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/703#discussion_r238742520
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/FLEOutOfElectionTest.java
---
@@ -0,0 +1,136 @@
+/**
+ * Licensed
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/715
This is the branch where my colleague Eric Schwartz and I are trying to get
to a "zero flaky tests" standard. (It started as the branch where I worked
on ZOOKEEPER-2778, and grew from
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/715
I'm not sure what this is. Do you have a corresponding jira?
---
16 matches
Mail list logo
