[GitHub] [zookeeper] enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

2019-05-02 Thread GitBox
enixon commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#issuecomment-488927170 @anmolnar I took your advice and dropped the attempt at creating a reconfig style test in favor of a direct test of the

[GitHub] [zookeeper] enixon edited a comment on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

2019-05-02 Thread GitBox
enixon edited a comment on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#issuecomment-488927170 @anmolnar I took your advice and dropped the attempt at creating a reconfig style test in favor of a direct test of

[jira] [Commented] (ZOOKEEPER-3319) Add metrics for follower and observer

2019-05-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832157#comment-16832157 ] Hudson commented on ZOOKEEPER-3319: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #504 (See

ZooKeeper-trunk - Build # 504 - Failure

2019-05-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/504/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 230.20 KB...] [junit] Tests run: 2, Failures: 0,

[jira] [Commented] (ZOOKEEPER-3319) Add metrics for follower and observer

2019-05-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832146#comment-16832146 ] Hudson commented on ZOOKEEPER-3319: --- FAILURE: Integrated in Jenkins build

[GitHub] [zookeeper] enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings

2019-05-02 Thread GitBox
enixon commented on issue #898: ZOOKEEPER-3353: Admin commands for showing initial settings URL: https://github.com/apache/zookeeper/pull/898#issuecomment-488867557 I have removed the four letter command version of these two endpoints. There does not appear to be any common place in

ZooKeeper_branch34_jdk8 - Build # 1786 - Still Failing

2019-05-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1786/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.38 KB...] [junit] Running

[GitHub] [zookeeper] enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size

2019-05-02 Thread GitBox
enixon commented on issue #770: ZOOKEEPER-3244: Add option to snapshot based on log size URL: https://github.com/apache/zookeeper/pull/770#issuecomment-488862814 Rebased to deal with conflicts in SyncRequestProcessor; all comments have been addressed.

[jira] [Assigned] (ZOOKEEPER-3319) Add metrics for follower and observer

2019-05-02 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv reassigned ZOOKEEPER-3319: - Assignee: Jie Huang > Add metrics for follower and observer >

[GitHub] [zookeeper] asfgit closed pull request #856: ZOOKEEPER-3319: Add metrics for follower and observer

2019-05-02 Thread GitBox
asfgit closed pull request #856: ZOOKEEPER-3319: Add metrics for follower and observer URL: https://github.com/apache/zookeeper/pull/856 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (ZOOKEEPER-3319) Add metrics for follower and observer

2019-05-02 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv resolved ZOOKEEPER-3319. --- Resolution: Fixed Issue resolved by pull request 856

[GitHub] [zookeeper] enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

2019-05-02 Thread GitBox
enixon commented on issue #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused URL: https://github.com/apache/zookeeper/pull/895#issuecomment-488853062 Any objections to merging code clean-up? This is an automated

ZooKeeper_branch34_openjdk7 - Build # 2293 - Failure

2019-05-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2293/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 47.57 KB...] [junit] Running

[GitHub] [zookeeper] anmolnar commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

2019-05-02 Thread GitBox
anmolnar commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-488725675 @BELUGABEHR Are there any existing unit tests which cover this functionality?

[GitHub] [zookeeper] brandon-miles commented on issue #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn…

2019-05-02 Thread GitBox
brandon-miles commented on issue #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn… URL: https://github.com/apache/zookeeper/pull/592#issuecomment-488721187 We were recently bitten by this. Is there any reason why the original commit was updated? It seemed like

[GitHub] [zookeeper] anmolnar commented on issue #928: ZOOKEEPER-3375. Docs enhancements for 3.5 release

2019-05-02 Thread GitBox
anmolnar commented on issue #928: ZOOKEEPER-3375. Docs enhancements for 3.5 release URL: https://github.com/apache/zookeeper/pull/928#issuecomment-488692409 @fpj @tdunning PTAL. This is an automated message from the Apache

[jira] [Updated] (ZOOKEEPER-3375) Docs enhancements for 3.5 release

2019-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3375: -- Labels: pull-request-available (was: ) > Docs enhancements for 3.5 release >

[GitHub] [zookeeper] anmolnar opened a new pull request #928: ZOOKEEPER-3375. Docs enhancements for 3.5 release

2019-05-02 Thread GitBox
anmolnar opened a new pull request #928: ZOOKEEPER-3375. Docs enhancements for 3.5 release URL: https://github.com/apache/zookeeper/pull/928 I need this PR to be merged to 3.5 before creating a new RC. - Backport latest release notes to 3.5 - Added comments on compiling with Java

[GitHub] [zookeeper] eolivelli commented on issue #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on issue #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#issuecomment-488646251 @brian-brazil if you want we can chat on gitter https://gitter.im/apache/apache-zookeeper

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280374268 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280373788 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280373799 ## File path:

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280373513 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] eolivelli commented on issue #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on issue #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#issuecomment-488630609 @brian-brazil Thank you so much for your feedback on this patch, which is still a draft I will take into consideration all of your

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280369671 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280369427 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280369140 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280368686 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280368422 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280368176 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280367616 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

Build failed in Jenkins: ZooKeeper-trunk-owasp #351

2019-05-02 Thread Apache Jenkins Server
See -- [...truncated 20.71 KB...] process-template: build-generated: [javac] Compiling 67 source files to

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280339241 ## File path:

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280338023 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280337846 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280337530 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280333964 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
eolivelli commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280337432 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280334605 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280334536 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280336092 ## File path:

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280335765 ## File path:

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280334763 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280336486 ## File path:

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280335012 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280334437 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280334840 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280334484 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@

[GitHub] [zookeeper] brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration

2019-05-02 Thread GitBox
brian-brazil commented on a change in pull request #927: ZOOKEEPER-3091 Prometheus.io integration URL: https://github.com/apache/zookeeper/pull/927#discussion_r280333964 ## File path:

[jira] [Commented] (ZOOKEEPER-1651) Add support for compressed snapshot

2019-05-02 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831483#comment-16831483 ] Andor Molnar commented on ZOOKEEPER-1651: - [~nixon] Awesome. Thank you. > Add support for

[jira] [Resolved] (ZOOKEEPER-1651) Add support for compressed snapshot

2019-05-02 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-1651. - Resolution: Fixed Fix Version/s: 3.6.0 > Add support for compressed snapshot