Re: Question about security configuration (was: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6)

2019-05-16 Thread Enrico Olivelli
Il ven 17 mag 2019, 01:18 Gracia, Raul ha scritto: > Hi Andor, > > You are totally correct, the server works adding this auth provider. > Thanks a lot! > > I did a cursory comparison between ZooKeeper versions 3.5.4-beta and 3.5.5 > and I couldn't find a change that justifies this behavior

[GitHub] [zookeeper] anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

2019-05-16 Thread GitBox
anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r284974888 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20

[GitHub] [zookeeper] anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

2019-05-16 Thread GitBox
anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r284974695 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20

RE: Question about security configuration (was: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6)

2019-05-16 Thread Gracia, Raul
Hi Andor, You are totally correct, the server works adding this auth provider. Thanks a lot! I did a cursory comparison between ZooKeeper versions 3.5.4-beta and 3.5.5 and I couldn't find a change that justifies this behavior change. In any case, the Pravega build has passed with

[GitHub] [zookeeper] elireisman commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-16 Thread GitBox
elireisman commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-493230356 Yay! Been a while (!!!) but happy to chime in if you need me, thanks for rebasing this 

[jira] [Commented] (ZOOKEEPER-3237) Allow IPv6 wildcard address in peer config

2019-05-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841667#comment-16841667 ] Hudson commented on ZOOKEEPER-3237: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #524 (See

[GitHub] [zookeeper] enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

2019-05-16 Thread GitBox
enixon commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-493187070 retest this please This is an automated message from the Apache Git

[GitHub] [zookeeper] enixon commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information

2019-05-16 Thread GitBox
enixon commented on issue #947: ZOOKEEPER-3392: Add admin command to display last snapshot information URL: https://github.com/apache/zookeeper/pull/947#issuecomment-493186770 retest ant build This is an automated message

[GitHub] [zookeeper] enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush

2019-05-16 Thread GitBox
enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the transaction log flush URL: https://github.com/apache/zookeeper/pull/851#issuecomment-493186586 retest maven build This is an automated message from the

[GitHub] [zookeeper] eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider

2019-05-16 Thread GitBox
eolivelli commented on issue #918: ZOOKEEPER-3366: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider URL: https://github.com/apache/zookeeper/pull/918#issuecomment-493170070 @lvfangmin do you have time to finish your review? Thanks

[GitHub] [zookeeper] anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server

2019-05-16 Thread GitBox
anmolnar commented on issue #923: ZOOKEEPER-1426: add version command to the zookeeper server URL: https://github.com/apache/zookeeper/pull/923#issuecomment-493161575 @nkalmar I don't think those error messages are related to this patch. That's basically the expected behaviour of this

Re: Question about security configuration (was: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6)

2019-05-16 Thread Andor Molnar
Hi Raul, X509AuthenticationProvider is not registered in the embedded ZK. In server logs it says: "[epollEventLoopGroup-4-1] ERROR org.apache.zookeeper.server.NettyServerCnxnFactory - Auth provider not found: x509" It's done by QuorumPeerConfig.java:436 (configureSSLAuth()) when you run

[jira] [Commented] (ZOOKEEPER-3237) Allow IPv6 wildcard address in peer config

2019-05-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841521#comment-16841521 ] Hudson commented on ZOOKEEPER-3237: --- SUCCESS: Integrated in Jenkins build

RE: Question about security configuration (was: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6)

2019-05-16 Thread Gracia, Raul
Thanks Andor for your quick reply. Let me answer to your questions: 1) Yes, the problem is related to client/server communication using SSL, not related to Quorum SSL (we use a single Zookeeper process in our tests). I would like your feedback first to conclude if this is a problem in our

[jira] [Assigned] (ZOOKEEPER-3237) Allow IPv6 wildcard address in peer config

2019-05-16 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3237: --- Assignee: Brian Nixon > Allow IPv6 wildcard address in peer config >

[GitHub] [zookeeper] anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

2019-05-16 Thread GitBox
anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761#issuecomment-493090307 Committed to master branch. Thanks @enixon ! This is an

[jira] [Resolved] (ZOOKEEPER-3237) Allow IPv6 wildcard address in peer config

2019-05-16 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3237. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 761

[GitHub] [zookeeper] asfgit closed pull request #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config

2019-05-16 Thread GitBox
asfgit closed pull request #761: ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config URL: https://github.com/apache/zookeeper/pull/761 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] anmolnar commented on issue #915: ZOOKEEPER-3370 Remove SVN specific revision generation

2019-05-16 Thread GitBox
anmolnar commented on issue #915: ZOOKEEPER-3370 Remove SVN specific revision generation URL: https://github.com/apache/zookeeper/pull/915#issuecomment-493085224 retest this please This is an automated message from the

[GitHub] [zookeeper] anmolnar closed pull request #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn…

2019-05-16 Thread GitBox
anmolnar closed pull request #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn… URL: https://github.com/apache/zookeeper/pull/592 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] anmolnar commented on issue #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn…

2019-05-16 Thread GitBox
anmolnar commented on issue #592: ZOOKEEPER-3112: fix fd leak due to UnresolvedAddressException on conn… URL: https://github.com/apache/zookeeper/pull/592#issuecomment-493084748 Due to @PhantomThief 's comment, I'm closing this PR.

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493061694 @nkalmar Solution #2 seems to be feasible - I've just tried simple prototype in

Re: ZooKeeper and OSGi (maven)

2019-05-16 Thread Enrico Olivelli
Il giorno gio 16 mag 2019 alle ore 13:25 Norbert Kalmar ha scritto: > Hi Jiri, > > Thank you for investigating this issue. > > Short summary what we already talked about on the PR: > I don't think we can change the package name on 3.5 branch, even though > this is not exposed through the client

[jira] [Updated] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil

2019-05-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3263: -- Labels: pull-request-available (was: ) > Illegal reflective access in zookeer's

[GitHub] [zookeeper] anmolnar opened a new pull request #950: ZOOKEEPER-3263. Illegal reflective access in zookeer's kerberosUtil

2019-05-16 Thread GitBox
anmolnar opened a new pull request #950: ZOOKEEPER-3263. Illegal reflective access in zookeer's kerberosUtil URL: https://github.com/apache/zookeeper/pull/950 Fixes warning messages of JDK 9/11 by upgrading libraries and refactoring `KerberosUtils` based on experiences of

Re: ZooKeeper and OSGi (maven)

2019-05-16 Thread Norbert Kalmar
Hi Jiri, Thank you for investigating this issue. Short summary what we already talked about on the PR: I don't think we can change the package name on 3.5 branch, even though this is not exposed through the client API. But for 3.6, from my point of view, sure. But that would mean go with

ZooKeeper and OSGi (maven)

2019-05-16 Thread Jiří Ondrušek
Hi, I've created issue [1] with missing exported packages in osgi for zookeeper 3.4.10. Then I started to prepare maven OSGi packaging [2] for the higher version of ZooKeeper (in the PR for issue). I've tried to implement OSGi packaging with the low impact. So I've tried to create OSGi bundles

[GitHub] [zookeeper] JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493025000 I've sent email to zookeeper-dev mailing list: ZooKeeper and OSGi

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493025000 I've sent email to zookeeper-dev mailing list: > ZooKeeper and OSGi (maven)

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493017349 @nkalmar I've just asked for subscription to dev mailing list, then I'd be able to

[GitHub] [zookeeper] nkalmar edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
nkalmar edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493015133 We would still need to solve it for 3.5 branch. So, for me, creating a

[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493015133 We would still need to solve it for 3.5 branch. So, for me, creating a zookeeper-osgi

[GitHub] [zookeeper] JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493012808 @eolivelli @nkalmar I've found problem with current approach (2 bundles,

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-493012808 @eolivelli @nkalmar I've found problem with current approach (2 bundles, one is

[GitHub] [zookeeper] anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand

2019-05-16 Thread GitBox
anmolnar commented on a change in pull request #899: ZOOKEEPER-3354: Improve efficiency of DeleteAllCommand URL: https://github.com/apache/zookeeper/pull/899#discussion_r284615207 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java ## @@ -45,20

Re: Question about security configuration (was: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6)

2019-05-16 Thread Andor Molnar
Hi Raul, Thanks for the analysis. Let me ask a few questions, because I see some things that need to be clarified first. 1. This issue is only about server-client SSL scenario (not Quorum TLS), so it's possibly a regression in 3.5. Is that correct? 2. When running all Pravega tests against an

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492984271 I was able to install manually zookeeper with curator. But I had to change a little

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492974467 @nkalmar I've added OSGi support to zookeeper-jute. I had to change pockaging to

[GitHub] [zookeeper] nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
nkalmar commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492971219 What I meant in "private package" is that we do not expose any of this to clients. Jute

Question about security configuration (was: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6)

2019-05-16 Thread Gracia, Raul
Hi all, My name is Raúl Gracia and I work in the Pravega project (open-source project for data stream storage): http://pravega.io/. I'm currently working on a Pravega branch using "zookeeper-3.5.5-rc6", as we are interested on allowing Curator (4.0.1) to use a Zookeeper version with the

[GitHub] [zookeeper] JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek edited a comment on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492933860 @eolivelli Ok, i'll continue with osgi packaging. I'll apply this also to

[GitHub] [zookeeper] JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator)

2019-05-16 Thread GitBox
JiriOndrusek commented on issue #945: [ZOOKEEPER-3389] Zookeeper does not export all required packages in OSGi (needed for curator) URL: https://github.com/apache/zookeeper/pull/945#issuecomment-492933860 @eolivelli Ok, i'll continue with osgi packaging. I'll apply this also to