[GitHub] [zookeeper] phunt commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

2019-05-29 Thread GitBox
phunt commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-497200481 retest maven build This is an automated

Re: ZooKeeper-Find-Flaky-Tests job updated

2019-05-29 Thread Andor Molnar
In theory, not. But I'm worried about too. Enrico, can we have or already have a similar view of Maven builds in Jenkins? We'll also need a Maven based Find Flaky Test job too. Andor On Thu, May 30, 2019 at 1:43 AM Patrick Hunt wrote: > "less problems"? TBH the maven job seems super flakey

Re: [ANNOUNCE] New ZooKeeper committer: Norbert Kalmar

2019-05-29 Thread Michael Han
Congratulations Norbert! On Tue, May 28, 2019 at 2:29 PM Dinesh Appavoo wrote: > Awesome. Congrats Norbert! > > On Tue, May 28, 2019 at 10:51 AM Brian Nixon > wrote: > > > Congrats, Norbert! Well earned. > > > > On Mon, May 27, 2019 at 3:49 AM Andor Molnar > > > wrote: > > > > >

Re: [ANNOUNCE] New ZooKeeper committer: Enrico Olivelli

2019-05-29 Thread Michael Han
Congratulations Enrico! On Tue, May 28, 2019 at 2:05 PM Dinesh Appavoo wrote: > Great news. Congrats Enrico! > > On Tue, May 28, 2019 at 10:51 AM Brian Nixon > wrote: > > > Awesome! Congrats, Enrico! > > > > On Mon, May 27, 2019 at 3:56 AM Andor Molnar > > > wrote: > > > > > Congratulations

[GitHub] [zookeeper] hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-29 Thread GitBox
hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#issuecomment-497156627 >> if this config could be generalized to be used exclusively for socket connection timeout I am not sure

[GitHub] [zookeeper] hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-29 Thread GitBox
hanm commented on issue #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#issuecomment-497155402 When a leader is partitioned after LE, a smaller socket timeout value will make it faster to detect the partition.

[GitHub] [zookeeper] hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-29 Thread GitBox
hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r288816030 ## File path: conf/zoo_sample.cfg ## @@ -6,6 +6,9 @@ initLimit=10 # The number

[GitHub] [zookeeper] hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out

2019-05-29 Thread GitBox
hanm commented on a change in pull request #953: ZOOKEEPER-3398 Learner.connectToLeader() may take too long to time-out URL: https://github.com/apache/zookeeper/pull/953#discussion_r288816455 ## File path:

[GitHub] [zookeeper] hanm commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document

2019-05-29 Thread GitBox
hanm commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931#issuecomment-497152729 I agree the original statement is not very clear, but instead of changing it, how about actually

Re: ZooKeeper-Find-Flaky-Tests job updated

2019-05-29 Thread Patrick Hunt
"less problems"? TBH the maven job seems super flakey compared to what I'm seeing with Ant, a step down. I submitted a PR and it's failed maven multiple times with random failures: https://github.com/apache/zookeeper/pull/962 are we doing something different between the two? Patrick On Wed, May

[GitHub] [zookeeper] enixon commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-29 Thread GitBox
enixon commented on issue #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963#issuecomment-497144847 lgtm This is an automated message from the Apache Git Service. To

[jira] [Commented] (ZOOKEEPER-3382) Update Documentation: If you only have one storage device

2019-05-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851368#comment-16851368 ] Hudson commented on ZOOKEEPER-3382: --- SUCCESS: Integrated in Jenkins build

[jira] [Updated] (ZOOKEEPER-3407) Update POM file with new information

2019-05-29 Thread Lars Francke (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated ZOOKEEPER-3407: Summary: Update POM file with new information (was: Update POM with new mailing

[jira] [Updated] (ZOOKEEPER-3407) Update POM file with new information

2019-05-29 Thread Lars Francke (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Francke updated ZOOKEEPER-3407: Description: New mailing lists & Jenkins update > Update POM file with new information

[jira] [Updated] (ZOOKEEPER-3407) Update POM with new mailing lists

2019-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3407: -- Labels: pull-request-available (was: ) > Update POM with new mailing lists >

[GitHub] [zookeeper] lfrancke opened a new pull request #964: ZOOKEEPER-3407: Update POM file

2019-05-29 Thread GitBox
lfrancke opened a new pull request #964: ZOOKEEPER-3407: Update POM file URL: https://github.com/apache/zookeeper/pull/964 This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: ZooKeeper-Find-Flaky-Tests job updated

2019-05-29 Thread Enrico Olivelli
Good. I hope to be able to drop ant soon. Less jobs, less problems Enrico Il mer 29 mag 2019, 14:48 Andor Molnar ha scritto: > Hi! > > I’ve updated the job to run on all recent builds based on the following > view: > > https://builds.apache.org/view/S-Z/view/ZooKeeper/ < >

[jira] [Created] (ZOOKEEPER-3407) Update POM with new mailing lists

2019-05-29 Thread Lars Francke (JIRA)
Lars Francke created ZOOKEEPER-3407: --- Summary: Update POM with new mailing lists Key: ZOOKEEPER-3407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3407 Project: ZooKeeper Issue

[jira] [Updated] (ZOOKEEPER-3406) Update website for new mailing lists

2019-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3406: -- Labels: pull-request-available (was: ) > Update website for new mailing lists >

[GitHub] [zookeeper] lfrancke opened a new pull request #963: ZOOKEEPER-3406: Update website for new mailing lists

2019-05-29 Thread GitBox
lfrancke opened a new pull request #963: ZOOKEEPER-3406: Update website for new mailing lists URL: https://github.com/apache/zookeeper/pull/963 This updates the website with the new mailing lists. Probably makes sense to wait with merging until INFRA has completed the changes.

[jira] [Created] (ZOOKEEPER-3406) Update website for new mailing lists

2019-05-29 Thread Lars Francke (JIRA)
Lars Francke created ZOOKEEPER-3406: --- Summary: Update website for new mailing lists Key: ZOOKEEPER-3406 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3406 Project: ZooKeeper Issue

[NOTICE] Change of mailing list behavior (soon)

2019-05-29 Thread Lars Francke
In the next few days Jira & Git notifications will stop being sent to dev@zookeeper.apache.org. Only the creation of new issues will still be announced on dev@. For everything else notifications will be sent to issues@ (for Jira related things) and notifications@ (for Git related things). If

Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications - Take 2

2019-05-29 Thread Lars Francke
The two mailing lists have been created. I opened & < https://issues.apache.org/jira/browse/INFRA-1852 5> On Wed, May 29, 2019 at 11:34 PM Lars Francke wrote: > Thank you Norbert, I'll submit

Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications - Take 2

2019-05-29 Thread Lars Francke
Thank you Norbert, I'll submit You are right. I don't know either. But there's not really any written rules for this kind of change just a community consensus I believe. On Wed, May 29, 2019 at 12:02 PM Norbert Kalmar wrote: > There is a source for the website [1], and the generated live site

[jira] [Commented] (ZOOKEEPER-3382) Update Documentation: If you only have one storage device

2019-05-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851096#comment-16851096 ] Hudson commented on ZOOKEEPER-3382: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #544 (See

[GitHub] [zookeeper] anmolnar commented on issue #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device

2019-05-29 Thread GitBox
anmolnar commented on issue #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device URL: https://github.com/apache/zookeeper/pull/935#issuecomment-496980833 Merged to master. Thanks @BELUGABEHR ! This

[jira] [Resolved] (ZOOKEEPER-3382) Update Documentation: If you only have one storage device

2019-05-29 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3382. - Resolution: Fixed Issue resolved by pull request 935

[GitHub] [zookeeper] asfgit closed pull request #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device

2019-05-29 Thread GitBox
asfgit closed pull request #935: ZOOKEEPER-3382: Update Documentation: If you only have one storage device URL: https://github.com/apache/zookeeper/pull/935 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] anmolnar commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document

2019-05-29 Thread GitBox
anmolnar commented on issue #931: ZOOKEEPER-3373:need change description for "Single System Image" guarantee in document URL: https://github.com/apache/zookeeper/pull/931#issuecomment-496963385 @hanm @phunt Do you agree with this change?

[GitHub] [zookeeper] anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements

2019-05-29 Thread GitBox
anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-496959862 We have so many committers nowadays. @lvfangmin @eolivelli @nkalmar Would you please let me have one of your approvals? :)

[GitHub] [zookeeper] anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements

2019-05-29 Thread GitBox
anmolnar commented on issue #878: ZOOKEEPER-3339: Improve Debug and Trace Log Statements URL: https://github.com/apache/zookeeper/pull/878#issuecomment-496959084 retest maven build This is an automated message from the

[GitHub] [zookeeper] anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter

2019-05-29 Thread GitBox
anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter URL: https://github.com/apache/zookeeper/pull/941#issuecomment-496958325 @bd2019us This patch doesn't compile: ``` [ERROR]

[GitHub] [zookeeper] anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter

2019-05-29 Thread GitBox
anmolnar commented on issue #941: [ZOOKEEPER-3387] Use BufferedWriter instead of FileWriter URL: https://github.com/apache/zookeeper/pull/941#issuecomment-496956993 retest this please This is an automated message from the

[GitHub] [zookeeper] anmolnar commented on issue #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide

2019-05-29 Thread GitBox
anmolnar commented on issue #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide URL: https://github.com/apache/zookeeper/pull/903#issuecomment-496956167 @BELUGABEHR Could be right, but I feel I can argue with. Not sure though. I would really just fix the URL instead

[GitHub] [zookeeper] eolivelli commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor

2019-05-29 Thread GitBox
eolivelli commented on issue #905: ZOOKEEPER-3359: Batch commits in the CommitProcessor URL: https://github.com/apache/zookeeper/pull/905#issuecomment-496949661 This is cool @anmolnar @nkalmar please take a look as well. I will review as soon as I can. The change is not trivial

[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

2019-05-29 Thread GitBox
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948713 @nkalmar I have restarted the tests because this patch was approved but it is quite old. I hope

[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

2019-05-29 Thread GitBox
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948507 retest maven build This is an

[GitHub] [zookeeper] eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory

2019-05-29 Thread GitBox
eolivelli commented on issue #912: ZOOKEEPER-3365: Use Concurrent HashMap with Counter in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/912#issuecomment-496948413 retest ant build This is an automated

[GitHub] [zookeeper] eolivelli commented on issue #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK

2019-05-29 Thread GitBox
eolivelli commented on issue #919: ZOOKEEPER-3356: Implement advanced Netty flow control based on feedback from ZK URL: https://github.com/apache/zookeeper/pull/919#issuecomment-496948152 @lvfangmin we need to rebase. I hope @normanmaurer have cycles to take a look

[GitHub] [zookeeper] eolivelli commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader

2019-05-29 Thread GitBox
eolivelli commented on issue #939: ZOOKEEPER-3385: Add admin command to display leader URL: https://github.com/apache/zookeeper/pull/939#issuecomment-496947055 Please rebase @enixon This is an automated message from the

[GitHub] [zookeeper] eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE

2019-05-29 Thread GitBox
eolivelli commented on issue #962: ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP CVE URL: https://github.com/apache/zookeeper/pull/962#issuecomment-496946298 retest maven build This is an automated

ZooKeeper-Find-Flaky-Tests job updated

2019-05-29 Thread Andor Molnar
Hi! I’ve updated the job to run on all recent builds based on the following view: https://builds.apache.org/view/S-Z/view/ZooKeeper/ Andor

Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications - Take 2

2019-05-29 Thread Norbert Kalmar
There is a source for the website [1], and the generated live site [2]. Also, there is a guide [3] available. I'm not sure a committer vote is binding here? :) [1] https://gitbox.apache.org/repos/asf?p=zookeeper.git;a=shortlog;h=refs/heads/website [2]

Build failed in Jenkins: ZooKeeper-trunk-owasp #378

2019-05-29 Thread Apache Jenkins Server
See Changes: [nkalmar] ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY [nkalmar] ZOOKEEPER-3404: Downgrade BouncyCastle to 1.60 -- [...truncated 14.66

Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications - Take 2

2019-05-29 Thread Lars Francke
Can anyone tell me where the site source lives? I assumed but that was updated 18 months ago but the site has information on release 3.5.5 so there must be something else somewhere. On Wed, May 29, 2019 at 8:30 AM Lars Francke wrote: >

Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications - Take 2

2019-05-29 Thread Lars Francke
Alright, I'm closing this. I've requested both issues@ and notifications@ and will file the necessary tickets once that's done. You should get a mail to private@ but I'll also check the status. On Mon, May 27, 2019 at 11:54 PM Lars Francke wrote: > I'd like to close the vote but forgot to