Re: [Request for Review] ZOOKEEPER-837 Eliminate cycle dependency between ClientCnxn and ZooKeeper

2020-05-15 Thread tison
Never mind and thanks for reviewing :-) Best, tison. Andor Molnar 于2020年5月15日周五 下午9:44写道: > Apologies Tison, I’ll take a look once I have some free cycles. It’s a > very useful initiative, we’ve already tried that internally during the > Maven migration, but it turned out to be way too cumbers

[jira] [Created] (ZOOKEEPER-3831) Add a test that does a minimal validation of Apache Curator

2020-05-15 Thread Jordan Zimmerman (Jira)
Jordan Zimmerman created ZOOKEEPER-3831: --- Summary: Add a test that does a minimal validation of Apache Curator Key: ZOOKEEPER-3831 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3831 Proje

[jira] [Created] (ZOOKEEPER-3830) After add a new node, zookeeper cluster won't commit any proposal if this new node is leader

2020-05-15 Thread Keli Wang (Jira)
Keli Wang created ZOOKEEPER-3830: Summary: After add a new node, zookeeper cluster won't commit any proposal if this new node is leader Key: ZOOKEEPER-3830 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3830

Re: [Request for Review] ZOOKEEPER-837 Eliminate cycle dependency between ClientCnxn and ZooKeeper

2020-05-15 Thread Andor Molnar
Apologies Tison, I’ll take a look once I have some free cycles. It’s a very useful initiative, we’ve already tried that internally during the Maven migration, but it turned out to be way too cumbersome. I’m looking forward getting this into 3.7.0. Thanks, Andor > On 2020. May 15., at 11:40,

[Request for Review] ZOOKEEPER-837 Eliminate cycle dependency between ClientCnxn and ZooKeeper

2020-05-15 Thread tison
Hi zookeepers, Several months ago I pick up an old ticket[1] which aimed at improve codebase by eliminate cycle dependency between ClientCnxn and ZooKeeper. The corresponding PR[2] is totally internal codebase alteration and doesn't affect user API. So far, we gain one committer approval(thank eo