GitHub user ArneBachmann opened a pull request:

    https://github.com/apache/zookeeper/pull/105

    Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts

    I added a .gitattributes file into the bin/ folder with the startup scripts.
    It seems the official build servers build the ZK packages on a Windows 
machine (?), because even the Bash Shell scripts have CRLF line endings 
(extracted from the downloaded archive, not from a git checkout), which caused 
bug ZK-2625, as reported by me.
    Since I don't have a build server myself and would build under Linux, I 
cannot check if this PR fixes the bug, please advise.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ArneBachmann/zookeeper master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #105
    
----
commit 6b58447a5da859736cb019ff1c4e41d9dcb5bbe1
Author: Arne Bachmann <arne.bachm...@gmx.de>
Date:   2016-11-12T20:32:27Z

    Introduce explicit end-of-line setting for shell scripts.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to