[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: ZOOKEEPER-1045-br-3-4.patch > Support Quorum Peer mutual authentication via S

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693803#comment-15693803 ] Rakesh R commented on ZOOKEEPER-1045: - Attached new document. Following are the changes

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: QuorumPeer Mutual Authentication Via Sasl Feature Doc - 2016-Nov-25.pdf > Supp

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15692915#comment-15692915 ] Rakesh R commented on ZOOKEEPER-2479: - [~rgs], [~fpj], I've tried an attempt to fix your review

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689212#comment-15689212 ] Rakesh R commented on ZOOKEEPER-1045: - Good catch [~phunt]. bq. does

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15689185#comment-15689185 ] Rakesh R commented on ZOOKEEPER-1045: - OK, I'll take care this part in the next document revision

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687425#comment-15687425 ] Rakesh R commented on ZOOKEEPER-1045: - Thanks [~phunt] for the reply. I'll come back

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15678614#comment-15678614 ] Rakesh R commented on ZOOKEEPER-1045: - Thanks [~phunt] for the reviews. bq. I assume you're

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676303#comment-15676303 ] Rakesh R commented on ZOOKEEPER-2355: - Hi [~arshad.mohammad], it is better to open a pull request

[jira] [Commented] (ZOOKEEPER-2542) Update NOTICE file with Netty notice in 3.4

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676267#comment-15676267 ] Rakesh R commented on ZOOKEEPER-2542: - [~fpj], I've created a PR https://github.com/apache

[jira] [Commented] (ZOOKEEPER-2574) PurgeTxnLog can inadvertently delete required txn log files

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675825#comment-15675825 ] Rakesh R commented on ZOOKEEPER-2574: - Yes, I've identified few occurrences in the doc. One more

[jira] [Commented] (ZOOKEEPER-2574) PurgeTxnLog can inadvertently delete required txn log files

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675807#comment-15675807 ] Rakesh R commented on ZOOKEEPER-2574: - How about keeping only one jira open and close the other

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15666049#comment-15666049 ] Rakesh R commented on ZOOKEEPER-2479: - [~fpj], please let me know anything else to be done

[jira] [Commented] (ZOOKEEPER-2420) Autopurge deletes log file prior to oldest retained snapshot even though restore may need it

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662891#comment-15662891 ] Rakesh R commented on ZOOKEEPER-2420: - Thanks [~EdRowe] for the good work. Hi All, Like [~hanm

[jira] [Commented] (ZOOKEEPER-2574) PurgeTxnLog can inadvertently delete required txn log files

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662873#comment-15662873 ] Rakesh R commented on ZOOKEEPER-2574: - Good catch [~hanm]. Yes, both are addressing same problem

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654494#comment-15654494 ] Rakesh R commented on ZOOKEEPER-1045: - Few updates:- Attached new patch fixing Eugene Koontz's

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: QuorumPeer Mutual Authentication Via Sasl Feature Doc - 2016-Nov-10.pdf > Supp

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

/r/47354/diff/ Testing --- Added unit test cases to verify the changes. Thanks, Rakesh R

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: ZOOKEEPER-1045-br-3-4.patch > Support Quorum Peer mutual authentication via S

[jira] [Commented] (ZOOKEEPER-1582) EndOfStreamException: Unable to read additional data from client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653736#comment-15653736 ] Rakesh R commented on ZOOKEEPER-1582: - {{EndOfStreamException}} that mentioned in your comment

[jira] [Commented] (ZOOKEEPER-1582) EndOfStreamException: Unable to read additional data from client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653697#comment-15653697 ] Rakesh R commented on ZOOKEEPER-1582: - I think, Apache HBase mailing list is the right forum

[jira] [Commented] (ZOOKEEPER-2574) PurgeTxnLog can inadvertently delete required txn log files

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643171#comment-15643171 ] Rakesh R commented on ZOOKEEPER-2574: - Thank you [~abhishekrai]. I could see there are few more

[jira] [Updated] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2383: Attachment: ZOOKEEPER-2383.patch Attached patch including test cases to verify the changs w.r.t

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636680#comment-15636680 ] Rakesh R commented on ZOOKEEPER-2383: - Thanks [~fpj]. OK, I'll modify the test case and create

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636358#comment-15636358 ] Rakesh R commented on ZOOKEEPER-2383: - Will this proposed fix induce any other component

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635578#comment-15635578 ] Rakesh R commented on ZOOKEEPER-1045: - bq. There is a corner case about impersonating server

[jira] [Commented] (ZOOKEEPER-2592) Zookeeper is not recoverable once running system( machine on which zookeeper is running) is out of space

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635186#comment-15635186 ] Rakesh R commented on ZOOKEEPER-2592: - Sure, can close this. I'd like to see response from

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633544#comment-15633544 ] Rakesh R commented on ZOOKEEPER-2479: - OK, attached new patch generated from git master. >

[jira] [Updated] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2479: Attachment: ZOOKEEPER-2479.patch > Add 'electionTimeTaken' value in LeaderMXB

[jira] [Commented] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632783#comment-15632783 ] Rakesh R commented on ZOOKEEPER-2479: - bq. It seems zk svn trunk doesn't have the latest code

[jira] [Updated] (ZOOKEEPER-2479) Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2479: Summary: Add 'electionTimeTaken' value in LeaderMXBean and FollowerMXBean (was: Add

[jira] [Commented] (ZOOKEEPER-2479) Add 'fleTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632230#comment-15632230 ] Rakesh R commented on ZOOKEEPER-2479: - [~fpj], It seems [zk svn trunk|https://svn.apache.org

[jira] [Commented] (ZOOKEEPER-2479) Add 'fleTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631335#comment-15631335 ] Rakesh R commented on ZOOKEEPER-2479: - Thanks [~fpj] for the suggestion. Attached another patch

[jira] [Updated] (ZOOKEEPER-2479) Add 'fleTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2479: Attachment: ZOOKEEPER-2479.patch > Add 'fleTimeTaken' value in LeaderMXBean and FollowerMXB

[jira] [Commented] (ZOOKEEPER-2592) Zookeeper is not recoverable once running system( machine on which zookeeper is running) is out of space

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631224#comment-15631224 ] Rakesh R commented on ZOOKEEPER-2592: - [~lasaro], Good to hear that the problem is resolved

[jira] [Commented] (ZOOKEEPER-2592) Zookeeper is not recoverable once running system( machine on which zookeeper is running) is out of space

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629334#comment-15629334 ] Rakesh R commented on ZOOKEEPER-2592: - Thanks [~rakeshsingh] for reporting this. I've few doubts

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15627693#comment-15627693 ] Rakesh R commented on ZOOKEEPER-1045: - Thanks a lot [~ekoontz] for the reviews. I will incorporate

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

> On Oct. 13, 2016, 9:57 p.m., Abraham Fine wrote: > > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, line 1134 > > > > > > is there a way for us to sanity check this (make sure that their > >

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review154255 --- Ship it! Ship It! - Rakesh R On Oct. 31, 2016, 4:31 a.m

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

(line 1134) <https://reviews.apache.org/r/51546/#comment223757> Thanks Abraham for bringing out this point. I'm OK with the clear documentation and the present explanation about the "inconsistent behabior" looks good to me. - Rakesh R On Oct. 31, 2016, 4:31 a.m., M

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620175#comment-15620175 ] Rakesh R commented on ZOOKEEPER-2014: - Thank you [~hanm] for the continuous effort. Sorry

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

> On Sept. 27, 2016, 6:37 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/KeeperException.java, line 317 > > <https://reviews.apache.org/r/51546/diff/3/?file=1510450#file1510450line317> > > > > Do we need @Deprecated constant value? Since we a

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

727> Many places its using deprecated APIs. Please visit all such occurances and replace with new API. Assert.assertTrue(e.getCode() == KeeperException.Code.NoAuth); replace with Assert.assertTrue(e.code() == KeeperException.Code.NOAUTH); - Rakesh R On Oct. 18,

[jira] [Commented] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15607177#comment-15607177 ] Rakesh R commented on ZOOKEEPER-2442: - Thanks [~hanm], [~cnauroth]. Merged to branch-3.5

[jira] [Updated] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2442: Fix Version/s: 3.5.3 > Socket leak in QuorumCnxManager connect

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

--- Added unit test cases to verify the changes. Thanks, Rakesh R

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: ZOOKEEPER-1045-br-3-4.patch Attached new patch with the following changes

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: QuorumPeer Mutual Authentication Via Sasl Feature Doc - 2016-Sep-25.pdf Attached

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: ZOOKEEPER-1045-br-3-4.patch I've attached another patch with few changes

[jira] [Commented] (ZOOKEEPER-2479) Add 'fleTimeTaken' value in LeaderMXBean and FollowerMXBean

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580154#comment-15580154 ] Rakesh R commented on ZOOKEEPER-2479: - [~fpj] could you please help me to push this in. Thanks

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580148#comment-15580148 ] Rakesh R commented on ZOOKEEPER-2355: - +1, latest patch looks good to me. ping [~fpj], [~rgs], I

[jira] [Updated] (ZOOKEEPER-2270) Allow MBeanRegistry to be overridden for better unit tests

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2270: Fix Version/s: (was: 3.4.7) > Allow MBeanRegistry to be overridden for better unit te

[jira] [Updated] (ZOOKEEPER-2271) Allow MBeanRegistry to be overridden for better unit tests in 3.4.x

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2271: Fix Version/s: 3.4.7 > Allow MBeanRegistry to be overridden for better unit tests in 3.

[jira] [Updated] (ZOOKEEPER-2270) Allow MBeanRegistry to be overridden for better unit tests

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2270: Fix Version/s: 3.4.7 3.5.2 3.6.0 > Allow MBeanRegis

[jira] [Updated] (ZOOKEEPER-2335) Java Compilation Error in ClientCnxn.java

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2335: Fix Version/s: 3.5.2 3.6.0 > Java Compilation Error in ClientCnxn.j

[jira] [Updated] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2442: Fix Version/s: 3.6.0 > Socket leak in QuorumCnxManager connect

[jira] [Commented] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580106#comment-15580106 ] Rakesh R commented on ZOOKEEPER-2442: - I think this has to be back ported to {{branch-3.5}}, shall

[jira] [Updated] (ZOOKEEPER-2576) After svn to git migration ZooKeeper Precommit jenkins job is failing.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2576: Fix Version/s: 3.6.0 > After svn to git migration ZooKeeper Precommit jenkins job is fail

[jira] [Commented] (ZOOKEEPER-2611) zoo_remove_watchers - can remove the wrong watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15579976#comment-15579976 ] Rakesh R commented on ZOOKEEPER-2611: - [~rgs], I've added the fix version to the jira, please feel

[jira] [Updated] (ZOOKEEPER-2611) zoo_remove_watchers - can remove the wrong watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2611: Fix Version/s: 3.6.0 3.5.3 > zoo_remove_watchers - can remove the wr

[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2467: Attachment: ZOOKEEPER-2467-br3-4.patch Attached committed patches to the jira. Following

[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2467: Fix Version/s: (was: 3.5.1) 3.6.0 > NullPointerException when r

[jira] [Updated] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2467: Attachment: ZOOKEEPER-2467.patch > NullPointerException when redo Command is passed negat

[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575545#comment-15575545 ] Rakesh R commented on ZOOKEEPER-2467: - Thanks [~rakeshkumarsingh]. +1, latest patch looks good

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568820#comment-15568820 ] Rakesh R commented on ZOOKEEPER-2355: - Thanks [~arshad.mohammad] for the patch. Just few comments

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568748#comment-15568748 ] Rakesh R commented on ZOOKEEPER-2355: - [~arshad.mohammad], Can you check 2nd point in the [review

[jira] [Commented] (ZOOKEEPER-2574) PurgeTxnLog can inadvertently delete required txn log files

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568287#comment-15568287 ] Rakesh R commented on ZOOKEEPER-2574: - Should we update the [zk docs|https://zookeeper.apache.org

[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559137#comment-15559137 ] Rakesh R commented on ZOOKEEPER-2467: - Like [~fpj] mentioned earlier, it is good to assert

[jira] [Commented] (ZOOKEEPER-2467) NullPointerException when redo Command is passed negative value

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551693#comment-15551693 ] Rakesh R commented on ZOOKEEPER-2467: - Thanks [~rakeshsingh] for your interest and taking

[jira] [Commented] (ZOOKEEPER-2587) Not handled negative scenario for redo command

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551561#comment-15551561 ] Rakesh R commented on ZOOKEEPER-2587: - Thanks a lot [~rakeshsingh] for reporting and working

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Component/s: (was: server) security quorum > Supp

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: ZOOKEEPER-1045-br-3-4.patch Thanks [~hanm] for the reviews. I'm attaching

[jira] [Comment Edited] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547752#comment-15547752 ] Rakesh R edited comment on ZOOKEEPER-1045 at 10/5/16 7:10 AM: -- Attached

[jira] [Comment Edited] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547752#comment-15547752 ] Rakesh R edited comment on ZOOKEEPER-1045 at 10/5/16 7:08 AM: -- Attached

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547752#comment-15547752 ] Rakesh R commented on ZOOKEEPER-1045: - Attached another patch in the [review ticket 47354|https

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547736#comment-15547736 ] Rakesh R commented on ZOOKEEPER-1045: - Reg this point there was a discussion in the review ticket

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47354/#review149501 --- On Oct. 5, 2016, 4:14 a.m., Rakesh R wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

* Now, the opened socket in connectOne is a strayed socket, and will > > not get used, or closed. > > > > If we put same check in connectOne, this problem can be fixed. Does > > this make sense for the case I am describing above? > > Rakesh R wr

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

sfully completed the authentication using SASL."); > > ... > > } Done - Rakesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47354/#review150630 -

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

xecutor and inprogressConnections into > > QuorumCnxManager? Both are implementation details around managing > > connections, and QuorumPeer does not need to know about these details. > > Abstract such details seems exactly what QuorumCnxManager was designed for. > > Rakesh

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

/apache/zookeeper/test/FLEPredicateTest.java 8088505 src/zookeeper.jute 6521e54 Diff: https://reviews.apache.org/r/47354/diff/ Testing --- Added unit test cases to verify the changes. Thanks, Rakesh R

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

PRE-CREATION src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 src/zookeeper.jute 6521e54 Diff: https://reviews.apache.org/r/47354/diff/ Testing --- Added unit test cases to verify the changes. Thanks, Rakesh R

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

the changes. File Attachments (updated) New patch addressing Michael's review comments https://reviews.apache.org/media/uploaded/files/2016/10/05/4dd9ed9a-817b-420b-bc6e-b638f6eaa7d9__ZOOKEEPER-1045-br-3-4-authz.patch Thanks, Rakesh R

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528370#comment-15528370 ] Rakesh R commented on ZOOKEEPER-2383: - [~fpj], any thoughts about the above points? Thanks

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527075#comment-15527075 ] Rakesh R commented on ZOOKEEPER-2014: - Thanks [~hanm] for working on this. I've added few comments

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

'false.'"); src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java (line 82) <https://reviews.apache.org/r/51546/#comment218623> Its good practise to add timeout in tests. may be smaller value can be given. @Test(timeout = 1000

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

ll be very confident that our change will not introduce any regressions. Yes, the SASL evaluation path may take at the magnitude of seconds. Again, this depends on the I/O resources(network speed etc). Its good point to maintain the existing code as it is and add the new code

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

tly what QuorumCnxManager was designed for. Agreed, I will change it. - Rakesh ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47354/#review149705 --- On Sept. 15, 2016, 4:48 p.m., Rakesh R wrote: >

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507169#comment-15507169 ] Rakesh R commented on ZOOKEEPER-2383: - bq. The test case isn't covering the whole modified code

[jira] [Comment Edited] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499350#comment-15499350 ] Rakesh R edited comment on ZOOKEEPER-2383 at 9/17/16 5:29 PM: -- Thanks

[jira] [Comment Edited] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499350#comment-15499350 ] Rakesh R edited comment on ZOOKEEPER-2383 at 9/17/16 5:21 PM: -- Thanks

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499350#comment-15499350 ] Rakesh R commented on ZOOKEEPER-2383: - Thanks [~fpj] for the comments. bq. In NettyServerCnxn

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495355#comment-15495355 ] Rakesh R commented on ZOOKEEPER-1045: - Great, thanks for your time and early feedback. > Supp

Re: Review Request 47354: ZOOKEEPER-1045 : Quorum mutual authentication using SASL mechanism

/FLEPredicateTest.java 8088505 src/zookeeper.jute 6521e54 Diff: https://reviews.apache.org/r/47354/diff/ Testing --- Added unit test cases to verify the changes. Thanks, Rakesh R

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493584#comment-15493584 ] Rakesh R commented on ZOOKEEPER-1045: - Attached another patch where I've tried to fix the flaky

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: ZOOKEEPER-1045-br-3-4.patch > Support Quorum Peer mutual authentication via S

[jira] [Comment Edited] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491138#comment-15491138 ] Rakesh R edited comment on ZOOKEEPER-1045 at 9/14/16 6:33 PM: -- Thanks

[jira] [Commented] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491138#comment-15491138 ] Rakesh R commented on ZOOKEEPER-1045: - Thanks a lot [~phunt], [~shralex], [~hanm

[jira] [Comment Edited] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491138#comment-15491138 ] Rakesh R edited comment on ZOOKEEPER-1045 at 9/14/16 6:32 PM: -- Thanks

[jira] [Updated] (ZOOKEEPER-1045) Support Quorum Peer mutual authentication via SASL

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Attachment: ZOOKEEPER-1045-br-3-4.patch > Support Quorum Peer mutual authentication via S

<    1   2   3   4   5   6   7   8   9   10   >