[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634365#comment-13634365 ] Shevek commented on ZOOKEEPER-1683: --- I think it looks OK. We put the code into

[jira] [Commented] (ZOOKEEPER-1677) Misuse of INET_ADDRSTRLEN

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633176#comment-13633176 ] Shevek commented on ZOOKEEPER-1677: --- Looks kosher to me. Note: I found this bug by

[jira] [Updated] (ZOOKEEPER-1684) Failure to update socket addresses on immedate connection

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shevek updated ZOOKEEPER-1684: -- Attachment: ZOOKEEPER-1684.diff My suggestion as a patch. Don't update variables; make things

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629780#comment-13629780 ] Shevek commented on ZOOKEEPER-1683: --- It's going to be a while, I'm afraid; I'm

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628622#comment-13628622 ] Shevek commented on ZOOKEEPER-1683: --- I think you can't just check isConnected() /

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628652#comment-13628652 ] Shevek commented on ZOOKEEPER-1683: --- volatile causes a write-read pair of the

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627493#comment-13627493 ] Shevek commented on ZOOKEEPER-1683: --- Actual testing failed, when first connected to

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627495#comment-13627495 ] Shevek commented on ZOOKEEPER-1683: --- sockKey == null, because previously:

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625596#comment-13625596 ] Shevek commented on ZOOKEEPER-1683: --- + if (lastIndex =0) { +

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625598#comment-13625598 ] Shevek commented on ZOOKEEPER-1683: --- Withdraw that; it's the previous server list.

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624039#comment-13624039 ] Shevek commented on ZOOKEEPER-1683: --- This may be caused by ClientCnxnSocketNIO.java:

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624042#comment-13624042 ] Shevek commented on ZOOKEEPER-1683: --- Note that since connect() is called by

[jira] [Created] (ZOOKEEPER-1684) Failure to update socket addresses on immedate connection

Shevek created ZOOKEEPER-1684: - Summary: Failure to update socket addresses on immedate connection Key: ZOOKEEPER-1684 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1684 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624086#comment-13624086 ] Shevek commented on ZOOKEEPER-1683: --- The trouble is that there's hidden state in

[jira] [Created] (ZOOKEEPER-1683) ZooKeeper client NPE when updating server list on disconnected client

Shevek created ZOOKEEPER-1683: - Summary: ZooKeeper client NPE when updating server list on disconnected client Key: ZOOKEEPER-1683 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1683 Project:

[jira] [Created] (ZOOKEEPER-1680) Cannot connect with a given sessionId - it is discarded

Shevek created ZOOKEEPER-1680: - Summary: Cannot connect with a given sessionId - it is discarded Key: ZOOKEEPER-1680 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1680 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-1677) Misuse of INET_ADDRSTRLEN

Shevek created ZOOKEEPER-1677: - Summary: Misuse of INET_ADDRSTRLEN Key: ZOOKEEPER-1677 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1677 Project: ZooKeeper Issue Type: Bug Affects

[jira] [Commented] (ZOOKEEPER-1677) Misuse of INET_ADDRSTRLEN

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616651#comment-13616651 ] Shevek commented on ZOOKEEPER-1677: --- Additional bugs: a) Since grow() does not zero