[GitHub] zookeeper pull request #439: ZOOKEEPER-1621: Delete and skip txn log with in...

2017-12-29 Thread abhishekrai
GitHub user abhishekrai opened a pull request: https://github.com/apache/zookeeper/pull/439 ZOOKEEPER-1621: Delete and skip txn log with incomplete header Based on the patch by Michi Mutsuzaki. When Zookeeper server encounters a txn log with incomplete header, the old

[GitHub] zookeeper issue #111: ZOOKEEPER-2574: PurgeTxnLog can inadvertently delete r...

2017-01-22 Thread abhishekrai
Github user abhishekrai commented on the issue: https://github.com/apache/zookeeper/pull/111 Thanks @hanm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zookeeper issue #111: ZOOKEEPER-2574: PurgeTxnLog can inadvertently delete r...

2016-12-13 Thread abhishekrai
Github user abhishekrai commented on the issue: https://github.com/apache/zookeeper/pull/111 Thanks for the review, I've updated the commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zookeeper pull request #111: ZOOKEEPER-2574: PurgeTxnLog can inadvertently d...

2016-12-13 Thread abhishekrai
Github user abhishekrai commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/111#discussion_r92156972 --- Diff: src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java --- @@ -108,9 +141,11 @@ public boolean accept(File f){ // remove

[GitHub] zookeeper pull request #111: ZOOKEEPER-2574: PurgeTxnLog can inadvertently d...

2016-12-13 Thread abhishekrai
Github user abhishekrai commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/111#discussion_r92156748 --- Diff: docs/zookeeperAdmin.html --- @@ -1201,8 +1205,10 @@ Configuration Parameters (Java system property: zookeeper.snapCount) ZooKeeper

[GitHub] zookeeper pull request #111: ZOOKEEPER-2574: PurgeTxnLog can inadvertently d...

2016-11-19 Thread abhishekrai
GitHub user abhishekrai opened a pull request: https://github.com/apache/zookeeper/pull/111 ZOOKEEPER-2574: PurgeTxnLog can inadvertently delete required txn log files … files This fix includes patch from Ed Rowe for ZOOKEEPER-2420, which is the same issue