Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
You are welcome.
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
Hi, @anmolnar @eolivelli . Is there anything I need to do before we merge
this PR?
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
@eolivelli @anmolnar Thanks for your approval.
---
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/294#discussion_r234997204
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java ---
@@ -69,9 +69,13 @@ public static void registerLog4jMBeans
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/294#discussion_r234959406
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java ---
@@ -69,9 +69,13 @@ public static void registerLog4jMBeans
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
@eolivelli Thanks for your comment. I will describe this variable in
`zookeeperJMX.md`.
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
@eolivelli Yep, I agree with you.
---
Github user asdf2014 commented on the pull request:
https://github.com/apache/zookeeper/commit/82da83a7176bbdd73dedb6fc3d96dac706cefad3#commitcomment-31341678
In zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java:
In zookeeper-server/src/main/java/org/apache
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/294#discussion_r234446570
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java ---
@@ -71,7 +71,7 @@ public static void registerLog4jMBeans() throws
GitHub user asdf2014 reopened a pull request:
https://github.com/apache/zookeeper/pull/294
ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer` in JMX module
The wrong `ObjectName` about `MBeanServer` in JMX module, should
`log4j:hierarchy=default` rather than `log4j:hiearchy
Github user asdf2014 closed the pull request at:
https://github.com/apache/zookeeper/pull/294
---
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/303#discussion_r181613274
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -71,7 +71,7 @@
* if serverAddresses is empty
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/296
@afine You are welcome :-)
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/296
@phunt @afine Thank you for those suggestions. Considered very thoughtful.
Already fixed.
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/296
Hi, @anmolnar . Thanks, would you approve this PR?
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/296
@afine Could you approve this PR?
@phunt @anmolnar PTAL.

Just recently, i experienced this situation again, this time due to the bad
disk rather than the huge WAL file
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Hi, @breed . Thanks for your comment. You are right, we should keep the
enough epoch value to avoid meet the epoch overflow. So i offer a better
solution is 24-bit epoch in second comment. Even
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Hi, @phunt . Indeed, the `FastLeaderElection` algorithm is very efficient.
Most of the leader election situation would finished in hundreds milliseconds.
However, some real-time stream
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
@JarenGlover It's a good idea, but not the best solution. Still we can
using the `restart` operation to solve this problem without any changes to
Zookeeper for now. (BTW, you are welcome to get
Github user asdf2014 closed the pull request at:
https://github.com/apache/zookeeper/pull/361
---
GitHub user asdf2014 reopened a pull request:
https://github.com/apache/zookeeper/pull/361
ZOOKEEPER-2892: Improve lazy initialize and close stream for
`PrepRequestProcessor`
Improve lazy initialize and close stream for `PrepRequestProcessor`
* Delay the initialization
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/361
@hanm Thanks for your suggestion. Conflicts has been fixed.
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/361
@hanm It works, thx a lot. ð
---
GitHub user asdf2014 reopened a pull request:
https://github.com/apache/zookeeper/pull/361
ZOOKEEPER-2892: Improve lazy initialize and close stream for
`PrepRequestProcessor`
Improve lazy initialize and close stream for `PrepRequestProcessor`
* Delay the initialization
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/361
Okay, I'll try it.
---
Github user asdf2014 closed the pull request at:
https://github.com/apache/zookeeper/pull/361
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/361
Seems like jenkins cannot work normally? @hanm
```bash
GitHub pull request #361 to apache/zookeeper
[EnvInject] - Loading node environment variables.
ERROR: SEVERE ERROR
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/361
ZOOKEEPER-2892: Improve lazy initialize and close stream for
`PrepRequestProcessor`
Improve lazy initialize and close stream for `PrepRequestProcessor`
* Delay the initialization
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/298#discussion_r131848354
--- Diff: src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java ---
@@ -52,12 +52,12 @@
private String members;
/* version
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/301
Hi @afine . Thanks for your comments. Your consider is entirely correct.
But I found the [PR#16937](https://github.com/elastic/elasticsearch/pull/16937)
from `elasticsearch`. And every node
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/304#discussion_r127135485
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/EphemeralNodeDeletionTest.java
---
@@ -0,0 +1,219 @@
+/**
+ * Licensed to the Apache
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/304#discussion_r127135317
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/EphemeralNodeDeletionTest.java
---
@@ -0,0 +1,219 @@
+/**
+ * Licensed to the Apache
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/302
Even if had been fixed the issues by adding the `START_SERVER_JVMFLAGS`
option, but i still don't understand why the execution of `mntr` 4lw command
would use the `JVMFLAGS` option. I list
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/304#discussion_r125798689
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/EphemeralNodeDeletionTest.java
---
@@ -0,0 +1,219 @@
+/**
+ * Licensed to the Apache
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/304#discussion_r125798526
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/EphemeralNodeDeletionTest.java
---
@@ -0,0 +1,219 @@
+/**
+ * Licensed to the Apache
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/303
ZOOKEEPER-2840: Should using `System.nanoTime() ^ this.hashCode()` foâ¦
Should using `System.nanoTime() ^ this.hashCode()` for StaticHostProvider
instead of `System.currentTimeMillis
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/302
ZOOKEEPER-2837: Add a special START_SERVER_JVMFLAGS option only for `start`
command to distinguish JVMFLAGS and SERVER_JVMFLAGS
Add a special START_SERVER_JVMFLAGS option only for `start
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/301
ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` jvm flag
Add `-XX:+AlwaysPreTouch` jvm flag for server, let jvm through
demand-zeroed way to allocate memory once in place when the process
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/296#discussion_r124950647
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -332,11 +333,13 @@ public synchronized void commit() throws
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/290
Hi, @afine. Thank you for code review. It maybe due to...
```java
// -ea -Xmx512M -Xms512M -Xmn256M -XX:+AlwaysPreTouch
@Test
public void testSingletonListPerformance
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/293#discussion_r124947780
--- Diff:
src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
---
@@ -28,24 +28,20 @@ public String getScheme
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/297#discussion_r124757125
--- Diff:
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java ---
@@ -590,14 +590,13 @@ public boolean
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/297#discussion_r124721264
--- Diff:
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java ---
@@ -590,14 +590,13 @@ public boolean
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/299
ZOOKEEPER-2827: Code refactoring for `JUTE` module
* Fix spell issues
* Simplify `return` clause
* Using enhanced `for` loop
* Using `try` clause to release the resource of stream
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/298
ZOOKEEPER-2826: Code refactoring for `CLI` module
* Fix spell issues
* Remove unnecessary `import`
* Make initialization block that related with `options.addOption` into
static
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/297
ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of
`indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage
for CLI module
* Remove unnecessary imp
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/296
ZOOKEEPER-2824: `FileChannel#size` info should be added to
`FileTxnLog#commit` to solve the confuse that reason is too large log or too
busy disk I/O
`FileChannel#size` info should be added
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/295
ZOOKEEPER-2823: 1. Fix spell issues; 2. Standardize `StringBuilder#append`
usage; 3. Using `try` clause for releasing I/O stream for `COMMON` module
* Fix spell issues
* Standardize
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/294
ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer` in JMX module
The wrong `ObjectName` about `MBeanServer` in JMX module, should
`log4j:hierarchy=default` rather than `log4j:hiearchy
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r124185161
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,94 @@
+/**
+ * Licensed
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/293
ZOOKEEPER-2821: 1. Fix spell issues; 2. Remove unnecessary boxing /
unboxing; 3. Simplify `return` clause; 4. Remove `final` qualifier from
`private` method
* Fix spell issues
* Remove
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/283
@hanm You are welcome :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/290
Using `Collections.singletonList` instead of `Arrays.asList(oneElement)`
Using `Collections.singletonList` instead of `Arrays.asList(oneElement)`
for reusing a immutable object instead
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/283
@hanm Already done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/288
@hanm Already done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/283
Hi, @hanm . I got it and i will create the jira. Sorry for bring the
`MINOR` habit from Apache Eagle..
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/288
MINOR: Code refactoring for `ZK_SERVER` module
* Fix spell issues
* Merge exception with `|` character
* Remove unnecessary boxing
* Remove unused import
* Remove unecessary
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/283
MINOR: 1. Fix streamsToFlush not completely empty problem; 2. Using try
clause to close resource; 3. Others code refactoring for PERSISTENCE module
MINOR:
* Fix streamsToFlush
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Hi, @yunfan123 . Thank you for your suggestion. As you said in the opinion,
so that it can guarantee a smooth upgrade. However, if the 16-bit `epoch`
overflow rather than the `counter` overflow
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
@maoling You are welcome. Already changed it into following
[code](https://github.com/apache/zookeeper/pull/262/files#diff-f4e58b67b9a4084420cb9b58398a953cR125).
Then, i think it can still
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Hi, @maoling. Thanks for your discussion. Maybe due to my description is
problematic, so make you confused.
1. I am worry about if the lower 8 bits of the upper 32 bits are divided
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Due to this [jvm
bug](http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7177813), JDK7 cannot
recognition `static import`... I will use fully qualified name replace of it.
```bash
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/262#discussion_r118176130
--- Diff:
src/contrib/loggraph/src/java/org/apache/zookeeper/graph/JsonGenerator.java ---
@@ -121,8 +121,8 @@ public JsonGenerator(LogIterator iter
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/262#discussion_r118168282
--- Diff:
src/contrib/loggraph/src/java/org/apache/zookeeper/graph/JsonGenerator.java ---
@@ -121,8 +121,8 @@ public JsonGenerator(LogIterator iter
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Seems like all test cases
[passed](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/738/testReport/),
but some problems happened in `Zookeeper_operations
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Why `jenkins` reported the following message:
```bash
mv:
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
and
'/home/jenkins/jenkins-slave
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Thinking about some abnormal situations, maybe 24 bit for `epoch` and 40
bit for `counter` is more better choice: $Math.min(2^{24} / (24 * 365), 2^{40}
/ (86400 * 1000 * 365)) \approx Math.min
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/262
ZOOKEEPER-2789: Reassign `ZXID` for solving 32bit overflow problem
If it is `1k/s` ops, then as long as $2^{32} / (86400 * 1000) \approx 49.7$
days ZXID will exhausted. But, if we reassign
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/257
I don't understand why `jenkins` reports `UnknownHostException`.
```java
java.net.UnknownHostException: 10.1.1.-113
at
java.net.AbstractPlainSocketImpl.connect
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600833
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600609
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -620,6 +625,7 @@ public void run() {
int
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600503
--- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java ---
@@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600449
--- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java ---
@@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600411
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -677,6 +686,7 @@ public void run
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600362
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -657,9 +663,12 @@ public void run
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600268
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -620,6 +625,7 @@ public void run() {
int
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600247
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -18,6 +18,12 @@
package
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600228
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -657,9 +663,12 @@ public void run
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600150
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -371,6 +372,10 @@ public void receiveConnection(Socket sock
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600142
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -545,6 +545,7 @@ public void testInconsistentPeerType() throws
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117599897
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -371,6 +372,10 @@ public void receiveConnection(Socket sock
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117599887
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117406260
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -660,6 +665,9 @@ public void run
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117400479
--- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java ---
@@ -18,36 +18,32 @@
package org.apache.zookeeper.test
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/257
Finally, it works :smile:
```bash
[exec] [junit] 2017-05-18 09:29:00,770 [myid:] - INFO
[main:ZKTestCase$1@58] - STARTING testSameSID
[exec] [junit] 2017-05-18 09
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/257
It's total fine in my local IDE...
---
If your project is set up for it, you
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/257
ZOOKEEPER-2784: Add same `sid` config problem check
Add some limitations on code level for `SID` to avoid configuration problem
You can merge this pull request into a Git repository by running
87 matches
Mail list logo
