Github user bothejjms commented on the issue:
https://github.com/apache/zookeeper/pull/563
I have refactored the branches as suggested.
---
Github user bothejjms commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/563#discussion_r205778339
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1128,9 +1128,9 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer
Github user bothejjms commented on the issue:
https://github.com/apache/zookeeper/pull/563
I have removed the test for now as I don't have a good way to test this
race condition. I can be reproduced easily by starting a server where the
globalOutstandingLimit is 1 and sending a lot
Github user bothejjms commented on the issue:
https://github.com/apache/zookeeper/pull/563
I have tweaked the test to use significantly less threads and be faster.
Unfortunately it still fails on jenkins. :(
I am not sure how ThreadPoolExecutor would help
Github user bothejjms commented on the issue:
https://github.com/apache/zookeeper/pull/563
On "pretty reliably" I mean the test has failed for me like 90% of the time
with the original code but the result can differ on different machines since it
is a race condition.
R
Github user bothejjms commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/563#discussion_r200961680
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1124,6 +1124,7 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer
GitHub user bothejjms opened a pull request:
https://github.com/apache/zookeeper/pull/563
Fix for ZOOKEEPER-3072
Making the throttle check before passing over the request to the next
thread will prevent the possibility of throttling code running after unthrottle
Added
