Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r225016751
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/command/HashCommand.java
---
@@ -0,0 +1,49 @@
+/**
+ * Licensed
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r225016824
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java ---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r225016598
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1566,179 @@ public boolean removeWatch(String path
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r225016509
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java ---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r225016431
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -154,6 +160,26 @@
private final
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224206365
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1566,179 @@ public boolean removeWatch(String path
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224208545
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -154,6 +160,26 @@
private final
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224212868
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataNode.java ---
@@ -37,6 +37,14 @@
*
*/
public class DataNode
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224210799
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NodeHashMapImpl.java
---
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224209494
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java ---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224206681
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1566,179 @@ public boolean removeWatch(String path
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224213395
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataNode.java ---
@@ -37,6 +37,14 @@
*
*/
public class DataNode
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r186694289
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -30,76 +31,118 @@
import org.slf4j.Logger;
import
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/466
Cool. :)
FYI, https://issues.apache.org/jira/browse/ZOOKEEPER-2693
Particularly, this quote:
_"A simple patch would provide a configuration option that disables these
4lw by de
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/466
@anmolnar Patrick is mentioning the plan to retire 4lw CLI commands in
favor of Restful web service version (based on Jetty). See
https://issues.apache.org/jira/browse/ZOOKEEPER-1346
---
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/476#discussion_r182127687
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java ---
@@ -927,10 +927,11 @@ public Vote lookForLeader() throws
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181267252
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
---
@@ -161,8 +127,8 @@ public void testLeaderInConnectingFollowers() throws
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181268803
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java ---
@@ -0,0 +1,140 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181267836
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -868,8 +868,8 @@ synchronized public long startForwarding(LearnerHandler
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181564184
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -916,7 +919,9 @@ public void waitForEpochAck(long id, StateSummary ss
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181267704
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181564082
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java ---
@@ -0,0 +1,140 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/500#discussion_r181266640
--- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java ---
@@ -0,0 +1,140 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/493
Hi @hanm,
Excuse me for the mess up and subsequent confusion. @edwardoliveira is me,
@eribeiro (on GH and JIRA), but I inadvertedly opened the PR using my second GH
account
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/493
@anmoldar thanks for the feedback! Gonna update the description and add a
test case asap. Btw, I am not the one who found this potential npe, but I am
glad to help. :) Last but not least, I
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/492
+1 lgtm
---
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/492#discussion_r175293565
--- Diff: src/java/main/org/apache/zookeeper/server/ContainerManager.java
---
@@ -116,8 +116,8 @@ public void checkContainers()
Request
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/479
LGTM. Let's wait for a commiter's review and Merge.
---
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r146108372
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +173,47 @@ synchronized public void resetRequestCounters
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r146108343
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -21,17 +21,32 @@
import org.apache.zookeeper.common.Time
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r146108249
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -21,17 +21,32 @@
import org.apache.zookeeper.common.Time
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/352
@minseclab Hi!
Please, **before opening a PR (and this one seems completely messed up) try
to post your question on ZookKeeper's user mailing list and, if and only if it
is bug
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/354
@hanm oh, totally my fault asking an already answered question. Excuse me.
Even tough, I see my (useless) question and your comment were roughly 9 hours
ago, and I remember very well the last
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/354
Late to the party but awesome work! Congrats! :+1:
@hanm are those changes applied to both master and branch-3.5? No
branch-4.5 backport, right?
---
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r135106003
--- Diff: src/java/test/org/apache/zookeeper/test/StringUtilTest.java ---
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/345#discussion_r135104691
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -20,8 +20,11 @@
import java.net.InetSocketAddress
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r131282046
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -460,11 +465,20 @@ public void processRequest(Request request
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r131281803
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -460,11 +465,20 @@ public void processRequest(Request request
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/325
+1. :+1:
@makubi could you confirm that this patch can be applied on branch-3.4 and
branch-3.5 too, please?
---
If your project is set up for it, you can reply to this email and have
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/320
LGTM, that is, on par with the version on `master/branch-3.5`. Wdyt @hanm ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/312
@CheneySun I see this patch doesn't apply to `branch-3.5/master` so make
sure you open another PR to address it on those branches. ð
---
If your project is set up for it, you can reply
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/312#discussion_r130229571
--- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxn.java ---
@@ -101,6 +102,13 @@ public boolean removeAuthInfo(Id id
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/312
@cheneysun mate, the description you wrote to @mhan should be **both** on
the JIRA description and this PR comment, not on review comments. It helps
setup context, motivation, etc. Keep
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/312
You can setup Netty by setting system property:
`zookeeper.serverCnxnFactory="org.apache.zookeeper.server.NettyServerCnxnFactory"`
Take a look at some test cases.
-
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/312
@CheneySun Don't forget to replicate these changes on `NettyServerCnxn`
and its factory. It's important to let them in sync as much as possible, even
more if you are adding a new data structure
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/312#discussion_r128688215
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -62,6 +63,10 @@
*/
final ByteBuffer directBuffer
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/312#discussion_r128688135
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -275,20 +307,9 @@ public synchronized void closeSession(long
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127618910
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -460,11 +464,21 @@ public void processRequest(Request request
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127627805
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127627537
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127619032
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -138,14 +145,56 @@ void delete(File f) throws IOException
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127627096
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -64,10 +65,15 @@
public MainThread(int
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127627334
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -292,6 +293,14 @@ public void parseProperties(Properties zkProp
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127618988
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -32,6 +32,7 @@
private long minLatency = Long.MAX_VALUE
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127628162
--- Diff:
src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java ---
@@ -27,6 +27,7 @@
import java.util.concurrent.CountDownLatch
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/307
@karanmehta93 hi, mate.
You don't need to touch `ZooKeeperAdmin.html` You change
`ZooKeeperAdmin.xml` **only** and Apache Forrest generate html anf PDF. Also,
this xml change should
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127172773
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -430,6 +432,7 @@ public void processRequest(Request request
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127110615
--- Diff: src/java/main/org/apache/zookeeper/server/Request.java ---
@@ -21,20 +21,27 @@
import java.nio.ByteBuffer;
import java.util.List
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127117526
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -430,6 +432,7 @@ public void processRequest(Request request
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127116226
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -430,6 +432,7 @@ public void processRequest(Request request
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127112584
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -735,6 +738,8 @@ public String getConfigFilename
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r12796
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -61,6 +61,7 @@
private static boolean
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127110211
--- Diff: src/java/main/org/apache/zookeeper/server/Request.java ---
@@ -121,6 +128,13 @@ public void setTxn(Record txn) {
this.txn = txn
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127109651
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -292,6 +293,8 @@ public void parseProperties(Properties zkProp
Github user eribeiro commented on the pull request:
https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886506
In src/java/test/org/apache/zookeeper/test/ACLTest.java:
In src/java/test/org/apache/zookeeper/test/ACLTest.java on line
Github user eribeiro commented on the pull request:
https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886495
In src/java/test/org/apache/zookeeper/test/ACLTest.java:
In src/java/test/org/apache/zookeeper/test/ACLTest.java on line
Github user eribeiro commented on the pull request:
https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886435
In src/java/test/org/apache/zookeeper/test/ACLTest.java:
In src/java/test/org/apache/zookeeper/test/ACLTest.java on line
Github user eribeiro commented on the pull request:
https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886377
In src/java/main/org/apache/zookeeper/ZooKeeper.java:
In src/java/main/org/apache/zookeeper/ZooKeeper.java on line 2380
Github user eribeiro commented on the pull request:
https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886369
In src/java/main/org/apache/zookeeper/ZooKeeper.java:
In src/java/main/org/apache/zookeeper/ZooKeeper.java on line 1439
Github user eribeiro commented on the pull request:
https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886375
In src/java/main/org/apache/zookeeper/ZooKeeper.java:
In src/java/main/org/apache/zookeeper/ZooKeeper.java on line 1538
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r121751200
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -915,11 +915,13 @@ protected void pRequest(Request request) throws
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r121749385
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -915,11 +915,13 @@ protected void pRequest(Request request) throws
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r121280799
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -915,11 +915,13 @@ protected void pRequest(Request request) throws
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r121280993
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -915,11 +915,13 @@ protected void pRequest(Request request) throws
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r121280641
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -915,11 +915,13 @@ protected void pRequest(Request request) throws
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r121281455
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1436,7 +1436,7 @@ public String create(final String path, byte data[],
List acl
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/238
Totally agree. It is worth another jira, for sure. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600729
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600572
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -620,6 +625,7 @@ public void run() {
int
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117574653
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -371,6 +372,10 @@ public void receiveConnection(Socket sock
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/238
Also, loops like the one below:
```
for (int idx = 0; idx < s.length(); idx++) {
char ch = s.charAt(idx);
```
could be simplified to `for (char
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/238
@alburthoffman @afine Hey guys, did you notice that the body of `bufEquals`
method could be replaced by `return Arrays.equals(onearray, twoarray);`?
In fact, the current implementation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117527100
--- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java ---
@@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117529199
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -371,6 +372,10 @@ public void receiveConnection(Socket sock
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117529736
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -545,6 +545,7 @@ public void testInconsistentPeerType() throws
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117441737
--- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java ---
@@ -351,15 +351,55 @@ public void testSocketTimeout() throws Exception
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117530984
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -677,6 +686,7 @@ public void run
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117528337
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117407300
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -657,9 +663,12 @@ public void run
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117403350
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -660,6 +665,9 @@ public void run
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117400348
--- Diff: src/java/test/org/apache/zookeeper/test/CnxManagerTest.java ---
@@ -18,36 +18,32 @@
package org.apache.zookeeper.test
Github user eribeiro closed the pull request at:
https://github.com/apache/zookeeper/pull/252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/252
As Ben pointed out, the docs at
http://zookeeper.apache.org/doc/r3.5.3-beta/zookeeperProgrammers.html#sc_ACLPermissions.
state clearly that "DELETE prevents deletion of chi
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/252
if approved this patch needs to be ported to branch-3.5 and master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/252#discussion_r116351552
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -389,8 +389,8 @@ protected void pRequest2Txn(int type, long zxid
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/252
ZOOKEEPER-2772: Delete node command does not honor Acl policy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER
Github user eribeiro closed the pull request at:
https://github.com/apache/zookeeper/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eribeiro closed the pull request at:
https://github.com/apache/zookeeper/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/243
ZOOKEEPER-2662: Export a metric for txn log sync times
Addressed review comments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113824039
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
@@ -113,6 +116,26 @@ public void testAutoCreateDb() throws
1 - 100 of 339 matches
Mail list logo
