Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113821610
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java ---
@@ -162,4 +162,12 @@ public String getSecureClientAddress
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113821590
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
* @return secure client address
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r11376
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
* @return secure client address
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r11385
--- Diff:
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
* @return secure client address
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/241
ZOOKEEPER-2662: Export a metric for txn log sync times
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/216
@afine I wonder if it is worth to backport this to branch-3.4... Wdyt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/217
@afine it would be possible to cherry pick this commit to branch-3.4, if it
also has those typos?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/205
@vincentpoon Very cool, Vincent! :smiley: Sorry, I didn't have any free
cycles to work on review comments regarding
https://github.com/apache/zookeeper/pull/208 but hopefully gonna merge
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/210
+1 to what @afine wrote. Plus, target your PR to **branch-3.4** and then we
can cherry-pick it into branch-3.5 and master after applying it to branch-3.4
---
If your project is set up
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108256234
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -524,17 +538,14 @@ public InetSocketAddress getLocalAddress
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108255892
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108242965
--- Diff:
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108242887
--- Diff:
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -84,4 +98,78 @@ public void testSendCloseSession() throws Exception
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108242277
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108242052
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -100,11 +101,15 @@ public void close
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108240078
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -170,7 +185,6 @@ public void messageReceived
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108239884
--- Diff:
src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java ---
@@ -51,9 +65,9 @@ public void setUp() throws Exception
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108027802
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -100,11 +101,15 @@ public void close
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/208#discussion_r108027783
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -109,6 +110,20 @@ public void channelConnected
Github user eribeiro closed the pull request at:
https://github.com/apache/zookeeper/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/77
Closing this PR as the patch has moved to
https://github.com/apache/zookeeper/pull/208 (still needs to address review
comments tough).
---
If your project is set up for it, you can reply
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/208
ZOOKEEPER-2280: NettyServerCnxnFactory doesn't implement maxClientCnxns
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r108010303
--- Diff: src/java/main/org/apache/zookeeper/common/TokenBucket.java ---
@@ -0,0 +1,88 @@
+/**
+* Licensed to the Apache Software Foundation (ASF
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r108009883
--- Diff: src/java/main/org/apache/zookeeper/common/TokenBucket.java ---
@@ -0,0 +1,88 @@
+/**
+* Licensed to the Apache Software Foundation (ASF
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r108009773
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -845,6 +845,40 @@ server.3=zoo3:2888:3888
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107821391
--- Diff: src/java/test/org/apache/zookeeper/test/MaxCnxnRateTest.java ---
@@ -0,0 +1,124 @@
+/**
+* Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107824008
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -39,6 +39,8 @@
import java.util.concurrent.ConcurrentHashMap
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107820652
--- Diff: src/java/main/org/apache/zookeeper/common/RateLimiter.java ---
@@ -0,0 +1,99 @@
+/**
+* Licensed to the Apache Software Foundation (ASF
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107822984
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -750,4 +761,46 @@ public static void setReconfigEnabled(boolean
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107822156
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -607,9 +618,28 @@ public static ByteBuffer getDirectBuffer
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107825507
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -607,9 +618,28 @@ public static ByteBuffer getDirectBuffer
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107825629
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -607,9 +618,28 @@ public static ByteBuffer getDirectBuffer
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107825073
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -845,6 +845,40 @@ server.3=zoo3:2888:3888
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107824726
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -794,8 +825,9 @@ public boolean removeCnxn(NIOServerCnxn cnxn
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107820601
--- Diff: src/java/main/org/apache/zookeeper/common/RateLimiter.java ---
@@ -0,0 +1,99 @@
+/**
+* Licensed to the Apache Software Foundation (ASF
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107822018
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -607,9 +618,28 @@ public static ByteBuffer getDirectBuffer
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107823274
--- Diff: src/java/test/org/apache/zookeeper/common/TokenBucketTest.java ---
@@ -0,0 +1,180 @@
+/**
+* Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107820676
--- Diff: src/java/main/org/apache/zookeeper/common/RateLimiter.java ---
@@ -0,0 +1,99 @@
+/**
+* Licensed to the Apache Software Foundation (ASF
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107820995
--- Diff: src/java/main/org/apache/zookeeper/common/RateLimiter.java ---
@@ -0,0 +1,99 @@
+/**
+* Licensed to the Apache Software Foundation (ASF
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107824547
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -607,9 +618,28 @@ public static ByteBuffer getDirectBuffer
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107825010
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -845,6 +845,40 @@ server.3=zoo3:2888:3888
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107821938
--- Diff: src/java/main/org/apache/zookeeper/common/TokenBucket.java ---
@@ -0,0 +1,88 @@
+/**
+* Licensed to the Apache Software Foundation (ASF
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/205#discussion_r107824798
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -817,24 +849,23 @@ public void touchCnxn(NIOServerCnxn cnxn
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/136
Hey @fpj, @phunt, @breed, @skamille (or any PMC/commiter), it would be
really cool to have this patch by @Randgalt merged, wouldn't it? If you have
any cycles would you mind to review this one
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/193
Hey @Randgalt, awesome work!
Pinging, @skamille @hanm @arshadmohammad to get their blessing. ;)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/192
Hi @Randgalt, congrats on getting this PR ported to 3.5! :smiley: Please,
could you close this PR as it has been merged? Best regards!
---
If your project is set up for it, you can reply
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/173
@JiangJiafu @rakeshadr @hanm @fpj Guys, does my considerations on this
comment https://github.com/apache/zookeeper/pull/173#discussion_r101845264 make
any sense? Probably it's just me being
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r102232941
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -303,15 +305,38 @@ public void loadData() throws IOException
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101969629
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -126,6 +125,9 @@
private final ZooKeeperServerListener listener
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101970085
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -303,15 +305,38 @@ public void loadData() throws IOException
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/173
@jiangjiafu glad to help. :) Thanks for driving this change. Great work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r101846854
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -113,13 +113,21 @@ private QuorumServer(long id, InetSocketAddress
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r101843694
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -128,24 +136,32 @@ private QuorumServer(long id, InetSocketAddress
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r101845264
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -181,6 +197,33 @@ public void recreateSocketAddresses
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r101843810
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -128,24 +136,32 @@ private QuorumServer(long id, InetSocketAddress
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r101843855
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -113,13 +113,21 @@ private QuorumServer(long id, InetSocketAddress
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r101843864
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -113,13 +113,21 @@ private QuorumServer(long id, InetSocketAddress
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r101843611
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -194,6 +237,12 @@ public void recreateSocketAddresses
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101836721
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -479,7 +479,7 @@ private boolean checkFourLetterWord(final SelectionKey
k
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101831774
--- Diff:
src/java/main/org/apache/zookeeper/server/command/SnapCommand.java ---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101829550
--- Diff:
src/java/main/org/apache/zookeeper/server/command/SnapCommand.java ---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101782717
--- Diff:
src/java/main/org/apache/zookeeper/server/command/SnapCommand.java ---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101779855
--- Diff:
src/java/main/org/apache/zookeeper/server/command/SnapCommand.java ---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/179
+1. Great work, @hanm. Congrats.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101667879
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +155,33 @@
*/
public final static
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101588332
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +155,33 @@
*/
public final static
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101587320
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +155,33 @@
*/
public final static
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101587208
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +155,33 @@
*/
public final static
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/165#discussion_r100232542
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,616 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/165#discussion_r100269807
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,616 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/165#discussion_r100269721
--- Diff: src/java/test/bin/test-github-pr.sh ---
@@ -0,0 +1,616 @@
+#!/usr/bin/env bash
+# Licensed under the Apache License, Version 2.0
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/169
Um... close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/168
@hanm Could you close this PR, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/170
I didn't catch anything worth comment. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/161
Hi @arshadmohammad, this PR was merged, right?
For whatever reason it was not closed. Could you close it, please? :)
---
If your project is set up for it, you can reply to this email
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/162
Hi @arshadmohammad, this PR was merged, right?
For whatever reason it was not closed. Could you close it, please? :)
---
If your project is set up for it, you can reply to this email
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/174
As far as I can infer, the current Jenkins errors (below) is because `ant`
was compiled on JDK8 and run on JDK7.
Exception in thread "main" java.lang.UnsupportedClassVe
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/174
Hi @rakeshadr, I have updated the PR for branch-3.5 and master. There's one
less changed file wrt branch-3.4
https://github.com/apache/zookeeper/commit
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/174
ZOOKEEPER-2617: correct a few spelling typos
Hi - this PR contains corrections for some spelling typos. Most of them
appear in comments, but a few appear in documentation and program output
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/127
@hanm @fpj Another PR not closed automatically. Flávio, could you close
it? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/156
@rakeshadr @hanm For whatever reason this PR was not closed. Could you
close it Michael?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98973726
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98968169
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1045,18 +1046,16 @@ private void getCounts(String path, Counts counts
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/160
@arshadmohammad My two last questions (really!):
* Is this change supposed to be applied to branch-3.4 and branch-3.5?
* I see that `DataNode.getChildren()` is called in half
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98745304
--- Diff: src/java/test/org/apache/zookeeper/server/DataNodeTest.java ---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98745482
--- Diff: src/java/test/org/apache/zookeeper/server/DataNodeTest.java ---
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98745143
--- Diff: src/java/test/org/apache/zookeeper/server/DataNodeTest.java ---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98710030
--- Diff: src/java/test/org/apache/zookeeper/server/DataNodeTest.java ---
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98709271
--- Diff: src/java/test/org/apache/zookeeper/server/DataNodeTest.java ---
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/160#discussion_r98662079
--- Diff: src/java/test/org/apache/zookeeper/server/DataNodeTest.java ---
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r98565216
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +75,106 @@ public
StaticHostProvider(Collection
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r98549400
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +75,106 @@ public
StaticHostProvider(Collection
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/160
+1. LGTM. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/157
Hey @revans2, FYI. I was able to apply the both #158 and #159 without any
explicit conflict on `branch-3.5` and `master` and #157 on branch-3.4 (but not
on the others cited previously). So
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r98484702
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -122,18 +122,19 @@ public int size() {
private int nextAdded
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r98392957
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +75,104 @@ public
StaticHostProvider(Collection
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r98282550
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +75,104 @@ public
StaticHostProvider(Collection
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r98281621
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +75,104 @@ public
StaticHostProvider(Collection
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r98280911
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +75,104 @@ public
StaticHostProvider(Collection
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r98265031
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +75,104 @@ public
StaticHostProvider(Collection
101 - 200 of 339 matches
Mail list logo
