Github user lujiefsi closed the pull request at:
https://github.com/apache/zookeeper/pull/544
---
Github user lujiefsi commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/544#discussion_r195967959
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -165,9 +168,13 @@ public void removeCnxn(NIOServerCnxn cnxn
GitHub user lujiefsi opened a pull request:
https://github.com/apache/zookeeper/pull/544
ZOOKEEPER-3009 : fix the related bugs in branch-3.4
The same problem that described in ZOOKEEPER-3009 also exists in
branch-3.4, just as @hanm said. I pull a new request to fix it. The patch
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/496
hum, too many commits, can we merge them as one commit, @brettKK
---
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/525
Hi: @phunt
Great suggestions for me I have update the bug description:
(1) getSocketAddress only has two callers, just as shown in description.
(2)addCnxn only has one caller, and
GitHub user lujiefsi opened a pull request:
https://github.com/apache/zookeeper/pull/525
[ZOOKEEPER-3009] Potential NPE in NIOServerCnxnFactory
We have developed a static analysis tool NPEDetector to find some potential
NPE. Our analysis shows that NPE reason can be simple:some
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/496
@anmolnar Local run is ok, @brettKK could you trigger another build
---
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/496
are the failure related to this patch???
---
Github user lujiefsi commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/496#discussion_r184676603
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
@@ -94,7 +94,10 @@ public void authenticate(Socket sock
Github user lujiefsi commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/496#discussion_r184675859
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
@@ -94,7 +94,10 @@ public void authenticate(Socket sock
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/495
Seems that unit test error is not caused by this patch?
---
Github user lujiefsi commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/496#discussion_r184251756
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
@@ -94,7 +94,10 @@ public void authenticate(Socket sock
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/495
@phunt
I got it. I have found all "deserialize" root caller and callsite postion:
(1)QuorumPeer#1208,#1154,#1152,#1182,#1154,#1194,#1195: their code have
same format:
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/495
@phunt :
I think the reason that @brettKK use RuntimeException to replace
NullPointerException is :(1)NullPointerException is subclass of
RuntimeException (2) give the semantic reason
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/495
Can we close it???
---
Github user lujiefsi commented on the issue:
https://github.com/apache/zookeeper/pull/496
Also ping @brettKK
---
16 matches
Mail list logo
