[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS

Github user sl4mmy commented on the issue: https://github.com/apache/zookeeper/pull/581 @anmolnar Done, and it passed. Thanks! ---

[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS

Github user sl4mmy commented on the issue: https://github.com/apache/zookeeper/pull/581 @nkalmar Thanks, I just pushed a new commit (slightly reworded the commit message) but the Jenkins build failed again for the same reason: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github

[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS

Github user sl4mmy commented on the issue: https://github.com/apache/zookeeper/pull/581 This commit just adds a comment so I'm not sure how it would cause a build failure other than a style alert, but that doesn't appear to be the case ---

[GitHub] zookeeper issue #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS

Github user sl4mmy commented on the issue: https://github.com/apache/zookeeper/pull/581 The Jenkins failure looks like an internal error in Jenkins itself: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1987/consoleText ---

[GitHub] zookeeper pull request #581: ZOOKEEPER-3101: add reminder to ZOO_ERRORS

GitHub user sl4mmy opened a pull request: https://github.com/apache/zookeeper/pull/581 ZOOKEEPER-3101: add reminder to ZOO_ERRORS Add comment at bottom of ZOO_ERRORS reminding developers to also update zerror(int) when adding or changing values. Suggested by @phunt in

[GitHub] zookeeper pull request #575: Zookeeper 3093

GitHub user sl4mmy opened a pull request: https://github.com/apache/zookeeper/pull/575 Zookeeper 3093 I noticed that zerror(ZNOWATCHER) returns "unknown error" and when I went to investigate why I realized that actually three new values were added to ZOO_ERRORS en

[GitHub] zookeeper issue #557: ZOOKEEPER-3077: build outside of source directory

Github user sl4mmy commented on the issue: https://github.com/apache/zookeeper/pull/557 No takers? :) I know this touches nasty autoconf stuff, but in my opinion it's actually simple & straight-forward: * At present you cannot build the native client in a

[GitHub] zookeeper pull request #559: ZOOKEEPER-3079: avoid unsafe use of sprintf(3)

Github user sl4mmy commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/559#discussion_r200184176 --- Diff: src/c/src/zookeeper.c --- @@ -4357,7 +4357,7 @@ int zoo_add_auth(zhandle_t *zh,const char* scheme,const char* cert, static const char

[GitHub] zookeeper pull request #559: ZOOKEEPER-3079: avoid unsafe use of sprintf(3)

GitHub user sl4mmy opened a pull request: https://github.com/apache/zookeeper/pull/559 ZOOKEEPER-3079: avoid unsafe use of sprintf(3) The function format_endpoint_info declares both addrstr and buf as 128 element char arrays, however on non-Windows platforms it calls sprintf

[GitHub] zookeeper pull request #558: ZOOKEEPER-3078: remove print_completion_queue

GitHub user sl4mmy opened a pull request: https://github.com/apache/zookeeper/pull/558 ZOOKEEPER-3078: remove print_completion_queue The fprintf(LOGSTREAM, ...) calls cause compiler errors when building with GCC 8: "error: null argument where non-null required"

[GitHub] zookeeper pull request #557: ZOOKEEPER-3077: build outside of source directo...

GitHub user sl4mmy opened a pull request: https://github.com/apache/zookeeper/pull/557 ZOOKEEPER-3077: build outside of source directory Allow building native C library outside of source directory by explicitly looking for jute generated header and source files inside source