[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496300939 I had enough with the failing Ant build, committed anyway. Thanks @jhuan31 !

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496295873 retest ant build This is an automated message from the Apache

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496267890 retest ant build This is an automated message from the Apache

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496253615 I think we really made something wrong with `testHostnameVerificationWithInvalidIpAddressAndInvalidHostname`. retest ant

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496253670 retest ant build This is an automated message from the Apache

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-496187671 retest ant build This is an automated message from the Apache

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495680030 @lvfangmin Are you happy with committing this patch? This is

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495679764 @eolivelli Please review again and make sure your comments have been addressed. I'll commit this once we got a green build.

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495275519 @jhuan31 Please fix the build error. (warnings are now treated as errors)

[GitHub] [zookeeper] anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics

anmolnar commented on issue #933: ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics URL: https://github.com/apache/zookeeper/pull/933#issuecomment-495273982 retest this please This is an automated message from the