[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-18 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249220918 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -17,10 +17,28

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-18 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249221188 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -403,6

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-18 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r249221054 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -17,11

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248851355 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -238,18

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248849244 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -238,18

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248847815 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -238,18

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848163 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKConfig.java ## @@ -18,6 +18,12

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248850022 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -406,26

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848936 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -513,4

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848580 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -406,26

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248804741 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6 +224,24

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248781573 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ## @@

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248781133 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ## @@

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248780258 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6 +224,24

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-16 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512821 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKClientSSLContext.java ## @@ -0,0

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-16 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513615 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -389,6

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-16 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512738 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -90,6 +89,7 @@

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-16 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513820 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -389,6

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-16 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512925 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6 +224,24

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-16 Thread GitBox
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513947 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ## @@