[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-08 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-461913343 retest this please This is an automated message from the

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-07 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-461379485 retest this please This is an automated message from the

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-07 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-461378932 Why is the build failing on javadocs warnings? Those are old warnings. I can fix them, it's just strange.

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-06 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-461070247 So this maven test fail still remains after backport, I might have merged a pom.xml incorrectly... need to check. Sadly rebase

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-06 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-461062394 Yes, and I just removed the empty jar generation This is an

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-06 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-461011491 @anmolnar So there weren't 100% agreement on how the release should look like, and unfortunately not many response came on

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-02-06 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-461010837 Hmm, this log4j error come with the rebase. Will look into it.

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-01-31 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-459574790 I will update the confluence page. When we finalize the release procedure, I will also update the README.md to display

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-01-30 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-459159366 Thanks guys, fixing them now. Also adding @lvfangmin to developers, using his public git profile to fill out the informations

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-01-24 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-457452543 Fixed the jars, added javadoc jar (turned off the errors as it would fail miserably due to lots of missing javadoc - still

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-01-24 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-457315231 Allright, moved it. This is an automated message from the

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-01-24 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-457289366 I moved the file, for now, it's as good as anywhere else.

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-01-24 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-457245932 Yes, it is ugly... that's where it should be according to maven standard library structure, but we can put it wherever we

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-01-23 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-457069058 Fixed the tarball. I tested by unzipping to a completely clear directory, the build should be working now. I will take

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

2019-01-16 Thread GitBox
nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-454703335 > I think we don't need so much assemblies. > Using plain Maven deployment features will result in a consistent artifact