Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/106
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/106
@arshadmohammad thanks for review, code is updated, please take a look at.
I also updated JIRA description so it's consistent with the pull request title.
---
If your project is set up for it, you
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/106
Jira ZOOKEEPER-1932 title is completely different from what is being done
in its MR. It think we should change the title as well as the description
---
If your project is set up for it,
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/106
Thanks @arshadmohammad
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user arshadmohammad commented on the issue:
https://github.com/apache/zookeeper/pull/106
I will review it soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/106
Need another committer view to merge this in; @arshadmohammad, can you
please review this? Flavio had +1 on an older version of the patch as commented
in JIRA, and this is only going to trunk.
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/106
PR updated:
* Removed LeaderElection class that not referenced anywhere.
* Fixed a couple of places in tests that still reference the LeaderElection
algorithm.
Would be good to
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/106
@lvfangmin Good catch, thanks for looking at the PR. I can't remember why
LeaderElection.java was not removed in the patch, let me double check before
updating the PR.
---
If your project is set
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/106
Since we're deprecating the LeaderElection, should we also remove
LeaderElection.java itself? Any reason we keep it there even no code is
referencing it?
---
If your project is set up for it,
