[GitHub] zookeeper issue #149: ZOOKEEPER-2664: ClientPortBindTest#testBindByAddress m...

2017-01-14 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/149 @hanm @tedyu Also, this ZOOKEEPER-2664 **sort of** duplicates https://issues.apache.org/jira/browse/ZOOKEEPER-2395 as far as I can see. Can we close it, too? Wdyt @phunt ? --- If

[GitHub] zookeeper issue #149: ZOOKEEPER-2664: ClientPortBindTest#testBindByAddress m...

2017-01-14 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/149 @hanm You are welcome! Just out curiosity, do we need to apply this patch to branch-3.5 and master too? /cc @tedyu --- If your project is set up for it, you can reply to this email and have

[GitHub] zookeeper issue #149: ZOOKEEPER-2664: ClientPortBindTest#testBindByAddress m...

2017-01-13 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/149 LGTM, merged. Thanks a lot @tedyu for your contribution to fix this test, that is much appreciated! Thanks @eribeiro for reviewing the patch as well. --- If your project is set up for it, you