Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/279
@jainbhupendra24 merged to master: d7c192c1829cc657d3312f47ecb5b97519d1b30d
Do you mind create separate pull requests targeting branch-3.5, and
branch-3.4 respectively? The current pull reque
Github user jainbhupendra24 commented on the issue:
https://github.com/apache/zookeeper/pull/279
@hanm , I will update the patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/279
Let's wrap this up before it becoming more stale. I believe the only
remaining work item is the last review comment @arshadmohammad made:
>> As this Validation we are doing multiple places it woul
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/279
>> Please refer the null check added in PrepRequestProcessor class in
server side to safeguard against NPE.
@jainbhupendra24 thanks for clarification.
---
If your project is set up for it
Github user jainbhupendra24 commented on the issue:
https://github.com/apache/zookeeper/pull/279
@hanm , Please refer the null check added in PrepRequestProcessor class in
server side to safeguard against NPE. Client side null check is added for
early validation and early feedback to
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/279
I am still not sure what this is about - there is no code change on server
(ZooKeeper.java is part of client library).
>> Handled Null case in server. Client will get InvalidACLException
Github user jainbhupendra24 commented on the issue:
https://github.com/apache/zookeeper/pull/279
Comments are replied and updated in latest patch. Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user jainbhupendra24 commented on the issue:
https://github.com/apache/zookeeper/pull/279
All review comments are taken care. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/279
Please also avoid unnecessary file permission changes (100644 â 100755 as
indicated by git diff).
Also a rebase is required as this PR is conflicting with
https://github.com/apache/zookeep
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/279
>> Handled Null case in server. Client will get InvalidACLException
I don't see what code changes included in this patch that's corresponding
to this. Maybe some changes were not uploaded?
Github user jainbhupendra24 commented on the issue:
https://github.com/apache/zookeeper/pull/279
All comments are addressed and CI failure is not related to this change.
Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user jainbhupendra24 commented on the issue:
https://github.com/apache/zookeeper/pull/279
Test failure is not related
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
12 matches
Mail list logo
