[GitHub] zookeeper issue #354: ZOOKEEPER-2630: Use interface type instead of implemen...

2017-09-11 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/354 @hanm oh, totally my fault asking an already answered question. Excuse me. Even tough, I see my (useless) question and your comment were roughly 9 hours ago, and I remember very well the last

[GitHub] zookeeper issue #354: ZOOKEEPER-2630: Use interface type instead of implemen...

2017-09-11 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/354 @eribeiro not sure why you asked - thought I made it clear that the patch for now only applied on master, because this pull request can't apply as is on other branches without some additional work

[GitHub] zookeeper issue #354: ZOOKEEPER-2630: Use interface type instead of implemen...

2017-09-11 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/354 Late to the party but awesome work! Congrats! :+1: @hanm are those changes applied to both master and branch-3.5? No branch-4.5 backport, right? ---

[GitHub] zookeeper issue #354: ZOOKEEPER-2630: Use interface type instead of implemen...

2017-09-11 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/354 @tamaashu This patch does not apply to branch-3.4 and branch-3.5. For now it's only applied on master and I resolved the JIRA with a target version of 3.6. If you'd like this land on 3.4 and 3.5,

[GitHub] zookeeper issue #354: ZOOKEEPER-2630: Use interface type instead of implemen...

2017-09-11 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/354 Committed to master: 1165794be9587a02782dbff95bc48528. ---

[GitHub] zookeeper issue #354: ZOOKEEPER-2630: Use interface type instead of implemen...

2017-09-01 Thread tamaashu
Github user tamaashu commented on the issue: https://github.com/apache/zookeeper/pull/354 fixed the issues with the imports --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature