Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/377
Never mind. I'll create a separate PR for that.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/377
@Randgalt Not strictly part of this PR, but I noticed that ContainerManager
doesn't log the name of the container being deleted here:
```java
try {
LOG.info("Attempting to
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/377
@afine This one is also an important PR to review and merge if you have a
chance. I think it's already in a good shape.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/377
@Randgalt @phunt I think this PR is in a pretty good shape, we should
finalize it. Any thoughts or outstanding concerns?
---
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
FYI - I just pushed a change that adds yet-another-flag that allows 3.5.4
ZKs to read the old 3.5.3 TTL nodes. I think we must have this. The docs are
updated too.
---
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
IMPORTANT NOTE: TTL Nodes created in 3.5.3 will revert to EPHEMERAL with
this change. We need to discuss the impact of this and consider workarounds,
etc.
---
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
Attn: @phunt - I just pushed two changes:
- Better docs and new reserved bits in the `EphemeralType` enum.
- Better implementation of the testable `serverId` in ZooKeeperServer.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/377
@Randgalt i'd really like to push out a 3.5.4 - do you think it would make
sense to release note this in 3.5.4 and address for 3.5.5? If you think we can
finalize this PR soon I'm still open to
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
Controlling TTL Nodes via zoo.cfg turned out to be untennable. There are
too many parts of the code that need to know about TTLs being enabled or not.
The previous PR had several holes relating
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/377
@Randgalt I had to resolve some conflicts in order to compare this to
current master. Posted the updated branch here:
https://github.com/phunt/zookeeper/commits/ZOOKEEPER-2901 Can you review this
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/377
I think it needs to do the same thing whether it's in standalone mode or
not. Least surprise. Also folks might want to test in standalone mode with the
same basic configuration that they use with
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
> I used the sample zoo.cfg file as my config and started via
bin/zkServer.sh - however I can still create a ttl based node even though
"ttlNodesEnabled=false" in the zoo.cfg. I recommend you
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/377
Hi @Randgalt - this looks like a reasonable change to me however it's not
working. I used the sample zoo.cfg file as my config and started via
bin/zkServer.sh - however I can still create a ttl
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
@phunt it's back to default false now. So, I hope this can be merged.
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/377
My "review" was a question. :-) Honestly I'm not sure what is the right
thing to do here. Afraid it's painted itself into a bit of corner.
---
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
@phunt you reviewed this PR originally so I was hoping you'd merge. @rgs1
can you merge if Pat can't?
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/377
@Randgalt I've been trying to focus on getting the branches, jenkins,
etc... back in shape so that I can cut some releases. Any chance your original
collaborators can help? I'm kinda swamped and
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
@phunt Can we get this merged please?
---
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
This feature is ready to merge (along with #378)
---
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
The integration above doesn't seem to update, but the build passes now.
---
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
FYI - I did some local ad-hoc testing with server IDs 254/255 and the
config value true/false in zoo.cfg and everything works as expected.
---
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/377
There are 4 tests with this line of code and it's failing because the
logger is not there (NullPointerException). Any ideas?
```
Layout layout =
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/377
The zoo_sample.cfg file should also be updated as part of this patch. It
should include the option, and IMO it should have ttl turned on by default
(similar warning wrt id as comment in the file?)
23 matches
Mail list logo
