Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/493
@edwardoliveira that's fine, I did not know that's you :-). Patch committed.
---
Github user LJ1043041006 commented on the issue:
https://github.com/apache/zookeeper/pull/493
Hi guys, **one more thing**
I have developed a very simple tool to find Potential NPE in
Zookeeper(based on [WALA](https://github.com/wala/WALA)), I list the result in
ZK-3007~3010
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/493
Hi @hanm,
Excuse me for the mess up and subsequent confusion. @edwardoliveira is me,
@eribeiro (on GH and JIRA), but I inadvertedly opened the PR using my second GH
account. :(
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/493
@edwardoliveira : could you please share your email so I can put it in
commit message when merge this?
Also, could you please create a JIRA account if you don't have one on
Github user edwardoliveira commented on the issue:
https://github.com/apache/zookeeper/pull/493
Hey, @LJ1043041006, I have just added a unit test. Cheers!
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/493
+1,LGTM
---
Github user LJ1043041006 commented on the issue:
https://github.com/apache/zookeeper/pull/493
@eribeiro , I found this potential npe and open issue
[zk-3006](https://issues.apache.org/jira/browse/ZOOKEEPER-3006), but i am not
very familiar with zookeeper code, so could you please
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/493
@anmoldar thanks for the feedback! Gonna update the description and add a
test case asap. Btw, I am not the one who found this potential npe, but I am
glad to help. :) Last but not least, I
Github user LJ1043041006 commented on the issue:
https://github.com/apache/zookeeper/pull/493
+1 lgtm, but "All checks have failed" makes me wonder and i think the
error is not cause by this patch, am i right.
---
