Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/566
lgtm. +1, thanks @cpoerschke .
Perhaps consider logging the value during startup (initial read of the
value) instead?
---
Github user cpoerschke commented on the issue:
https://github.com/apache/zookeeper/pull/566
Thanks everyone for your feedback!
> ... are you ok with removing the extra words in the log message?
Hmm, ok, done. Should I update the pull request and
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/566
i agree with @maoling, logging it with every warning seems overkill. the
rest of the change looks great though. are you ok with removing the extra words
in the log message?
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/566
Is is really necessary to log this property `fsync.warningthresholdms`?
---
