Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/647
Merged, close this PR.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
Merged. Thanks @lvfangmin !
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/647
@anmolnar should we get this in?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/647
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2518/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
@lvfangmin Sounds acceptable.
If the flaky cannot be fixed with my suggestion (waiting for client to
disconnect), let's put the retry back in.
I'll commit afterwards. Thanks.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/647
@anmolnar what's your opinion with @hanm 's reply?
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/647
I think we can add Retry rules as long as the cause of the flaky is clear
(e.g. this case, since ConnectionLoss is a well known flaky cause); what I
worried previously was to apply it unanimously
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/647
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2474/
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/647
@anmolnar I can understand your concern, let's remove the RetryRule for
now, we can add it when necessary.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
I still have bad feelings about introducing `RetryRule` in this patch. I
haven't seen connectionLoss errors recently on the builds, neither on this
patch after the fix and not sure it's a good
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/647
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2458/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/647
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2454/
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/647
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/647
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2389/
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/647
I remember I commented in Jira ZOOKEEPER-3157, not sure why it didn't show
up.
I mentioned that we still need RetryRule, because there might be temporary
quorum unstable issues like
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
@lvfangmin Given that I've already provided a fix for the flakyness in #657
, do we still need this retry rule?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/647
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2376/
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/647
>> I added a junit retry rule class to retry with specific exception
LGTM, thanks @lvfangmin
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/647
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2304/
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/647
@anmolnar @hanm I added a junit retry rule class to retry with specific
exception, currently I only use it to catch the connection loss exception in
FuzzySnapshotRelatedTest, we can use this in
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
I'll commit this once the testing part is finalized.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/647
@lvfangmin Got it. Fine. Go ahead please. Just make sure that all patches
go under the same Jira, so that they couldn't get lost.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/647
@anmolnar here is the scenario shows why the previous fix on master has
problem:
1. parent A is in it's parent's serializing list
2. before it's being serialized, child 1 was
24 matches
Mail list logo
