Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@anmolnar thanks for merging this :) I've rebased #679, #680, and #681 on
top of master. Let's get those in soon :)
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
Merged to 3.5 and master branches. Thanks @ivmaykov !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
Now it's green. I'll merge it.
Previously the findbugs subprocess has been killed for some reason.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2604/
---
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/678
Yeah, there aren't findbugs reports in the artifacts as I would expect
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/artifact/patchprocess/
, it's unclear what went wrong
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@anmolnar the latest attempt does not have test failures, but claims a
findbugs failure.
>[exec] -1 overall. GitHub Pull Request Build
>[exec]
>[exec]
>
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
It's not findbugs, core and contrib tests are failing, but I cannot see why:
```
[exec] -1 core tests. The patch failed core unit tests.
[exec] -1 contrib
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
Jenkins claims there is a findbugs failure, but there is no actual output
of findbugs failures, and findbugs passes on my machine. ¯\_(ã)_/¯
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
I don't understand why this PR started failing Jenkins builds all of a
sudden. The next 2 PRs stacked on this one (#678 and #680) also fail, but the
last one (#681) passes.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
@ivmaykov It's in:
`zookeeper-server/src/test/resources/test-github-pr.sh`
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
Maybe you should use docker.
As soon as possible I will copy the command line we are using in Jenkins
job.
Maybe it is already available on the job log
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@anmolnar is there a way to reproduce the exact same steps that jenkins
runs on my macbook?
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@anmolnar it works for me as far as I can tell, I think the contbuild is
flaky? The contbuild on #681, which includes the same commit, passes.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
What's wrong with this build?
@ivmaykov Does it work for you locally?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2589/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2584/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2563/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@anmolnar on my machine it worked, but on Jenkins it could not resolve the
import - not sure why. It's not a big deal I think, we don't need to use it.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/678
@ivmaykov What was the problem with using `FileNameUtils`?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2559/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2555/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@eolivelli got it, thanks! I will use that terminology from now on :)
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
'Non binding' means that I am not a 'committer' so I can't merge the patch
by myself.
Btw the other guys which are reviewing this patch are committers so I think
this patch will be merged
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@eolivelli what does a "(non binding)" +1 mean? Can we merge this to
upstream/master at this point?
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
Revert `FileNameUtils` change as it seems to be breaking contbuild
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2548/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2544/
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
For Apache httpcomponents there is nothing to write, the NOTICE already
covers it, as it is an Apache Project
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refactored common code shared by a bunch of tests that use
`X509TestContext` into a new base class, `BaseX509ParameterizedTestCase`.
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@eolivelli capitalized "Airlift" in NOTICE.txt
@anmolnar use `FileNameUtils.getExtension()` for file type detection
everyone: fixed some copy-paste bugs in PEMFileLoaderTest and
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@anmolnar it's certainly easier to keep track of the copied code if we
don't modify it much. Moving the logic into PEMFileLoader and making it
non-static would make it harder to trace the
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2536/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2532/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@anmolnar added KeyStoreLoader classes
@eolivelli updated NOTICE file and PemReader.java
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
I should mention that this code has been internally reviewed at Facebook,
has been landed on our internal fork, and has been running in production for
weeks.
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
@ivmaykov
The code can stay where you put it.
About the NOTICE file I will try to help past the weekend
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2521/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2525/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
@eolivelli should the copied code be put into the zookeeper-contrib
subproject? Or can it still live in zookeeper-server? I could also use help
with wording the message in the NOTICE file.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2514/
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/678
>> is there a way to trigger a Jenkins build re-run?
@ivmaykov Check out
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute, search
'Jenkins Pre-commit Check'. The
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
retest this please
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/678
The test failures don't look to be related to my changes. @anmolnar @hanm
is there a way to trigger a Jenkins build re-run?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/678
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2500/
---
46 matches
Mail list logo
