Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/692
Committed to `website` branch. Thanks @tamaashu !
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/692
@lvfangmin How about now?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/692
I'm still happy with the changes. Confirmed that we don't need any special
approval for website changes. @hanm @lvfangmin any objections?
---
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/692
Hi @hanm,
> * The layout is a little bit odd - can we remove the empty spaces on both
left and right side of the web page? Use HBase main page for a reference:
https://hbase.apache.org/.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/692
Nice work @tamaashu ! some feedback:
* The layout is a little bit odd - can we remove the empty spaces on both
left and right side of the web page? Use HBase main page for a reference:
https
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/692
I also like the design, compared to HBase, I can definitely see the
inspiration :)
Good job, +1 non-binding
---
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/692
@anmolnar yes. This design is responsive, adopts to the screen size,
simple, easy to read, but still modern. It's close to HBase's design, but since
I've used 2 version newer bootstrap it differs
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/692
Do you have a preview in some staging site?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/692
@tamaashu Have you changed the design of the website intentionally?
---
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/692
Hi @eolivelli, could you please check it again? Since I changed it
fundamentally, I think it needs a new review.
@anmolnar, @hanm could you please review these changes?
Thanks.
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/692
> Awesome work
>
> May we rename 'hbase' files to 'zookeeper' ?
Even removed them. I've updated to the newest BootStrap, where I've dropped
everything I copied from HBase.
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/692
Awesome work
May we rename 'hbase' files to 'zookeeper' ?
Is bootstrap compatible from a licensing perspective? Should we add some
'NOTICE' ?
---
12 matches
Mail list logo
