[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user pravsingh commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r205904126 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -66,8 +67,8 @@ public SaslQuorumAuthLearner(boolean

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user lujiefsi commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r184676603 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -94,7 +94,10 @@ public void authenticate(Socket sock,

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user lujiefsi commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r184675859 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -94,7 +94,10 @@ public void authenticate(Socket sock,

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user lujiefsi commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r184251756 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -94,7 +94,10 @@ public void authenticate(Socket sock,

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r184218439 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -94,7 +94,10 @@ public void authenticate(Socket sock,

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

GitHub user brettKK reopened a pull request: https://github.com/apache/zookeeper/pull/496 ZOOKEEPER-3008: Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate @LJ1043041006 found a potential NPE in ZK callee

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user brettKK closed the pull request at: https://github.com/apache/zookeeper/pull/496 ---

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

GitHub user brettKK reopened a pull request: https://github.com/apache/zookeeper/pull/496 ZOOKEEPER-3008: Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate @LJ1043041006 found a potential NPE in ZK callee

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user brettKK closed the pull request at: https://github.com/apache/zookeeper/pull/496 ---

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r177697912 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -134,6 +138,8 @@ public void authenticate(Socket

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

Github user LJ1043041006 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/496#discussion_r177685103 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java --- @@ -94,7 +94,7 @@ public void authenticate(Socket

[GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...

GitHub user brettKK opened a pull request: https://github.com/apache/zookeeper/pull/496 ZOOKEEPER-3008: Potential NPE in SaslQuorumAuthLearner#authenticate and SaslQuorumAuthServer#authenticate @LJ1043041006 found a potential NPE in ZK callee