[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user lavacat closed the pull request at: https://github.com/apache/zookeeper/pull/500 ---

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182922147 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182889043 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182887771 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java --- @@ -0,0 +1,140 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182180406 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -161,8 +127,8 @@ public void testLeaderInConnectingFollowers()

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r182128913 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -161,8 +127,8 @@ public void testLeaderInConnectingFollowers() throws

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181267252 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -161,8 +127,8 @@ public void testLeaderInConnectingFollowers() throws

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181268803 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java --- @@ -0,0 +1,140 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181267836 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -868,8 +868,8 @@ synchronized public long startForwarding(LearnerHandler

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181564184 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -916,7 +919,9 @@ public void waitForEpochAck(long id, StateSummary ss)

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181267704 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181564082 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java --- @@ -0,0 +1,140 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181266640 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java --- @@ -0,0 +1,140 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181002193 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181001854 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r180789703 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r180793047 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

GitHub user lavacat opened a pull request: https://github.com/apache/zookeeper/pull/500 ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers https://issues.apache.org/jira/browse/ZOOKEEPER-2959 - add getVotingView check for id in getEpochToPropose and