[GitHub] zookeeper pull request #563: Fix for ZOOKEEPER-3072

2018-07-10 Thread nkalmar
Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/563#discussion_r201258688 --- Diff: src/java/test/org/apache/zookeeper/test/ThrottleRaceTest.java --- @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #563: Fix for ZOOKEEPER-3072

2018-07-09 Thread bothejjms
Github user bothejjms commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/563#discussion_r200961680 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -1124,6 +1124,7 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer

[GitHub] zookeeper pull request #563: Fix for ZOOKEEPER-3072

2018-07-09 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/563#discussion_r200956044 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -1124,6 +1124,7 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer

[GitHub] zookeeper pull request #563: Fix for ZOOKEEPER-3072

2018-07-06 Thread bothejjms
GitHub user bothejjms opened a pull request: https://github.com/apache/zookeeper/pull/563 Fix for ZOOKEEPER-3072 Making the throttle check before passing over the request to the next thread will prevent the possibility of throttling code running after unthrottle Added an