[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-14 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/624#discussion_r217873847 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -265,18 +266,25 @@ server.3=zoo3:2888:3888 role="bold">ser

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-14 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/624#discussion_r217873955 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -265,18 +266,25 @@ server.3=zoo3:2888:3888 role="bold">ser

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-14 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/624#discussion_r217812851 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -265,18 +266,25 @@ server.3=zoo3:2888:3888 role="bold">se

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-14 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/624#discussion_r217763082 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java --- @@ -83,7 +83,7 @@ public QuorumMaj(Properties props) throws Confi

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-13 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/624 ZOOKEEPER-3108:use a new property server.id in the zoo.cfg to substitute for myid file - use a new property `server.id` in the `zoo.cfg` to substitute for `myid `file,If the unique id is both se