Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97451441
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -434,6 +434,10 @@ public int getQuorumSize(){
//last proposed
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97451281
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -468,31 +469,33 @@ synchronized private boolean connectOne(long sid,
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97266698
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -468,31 +469,33 @@ synchronized private boolean connectOne(long
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r96929565
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -434,6 +434,10 @@ public int getQuorumSize(){
//last proposed
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r90916712
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1390,24 +1406,29 @@ public QuorumVerifier configFromString(String s)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r90764675
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1390,24 +1406,29 @@ public QuorumVerifier configFromString(String s)
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/92
ZOOKEEPER-2080: Fix deadlock in dynamic reconfiguration.
Use explicit fine grained locks for synchronizing access to QuorumVerifier
states in QuorumPeer.
You can merge this pull request into a Git