Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-10 Thread Norbert Kalmar
I added the suggestions to the jira. Thanks all! On Thu, May 10, 2018 at 3:34 AM Prasanth Mathialagan < prasanthmathiala...@gmail.com> wrote: > Hi, > This looks cool :) I have a suggestion. It would be nice if we could add > the current size of the heap or (% of heap used) in the log entry whene

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Prasanth Mathialagan
Hi, This looks cool :) I have a suggestion. It would be nice if we could add the current size of the heap or (% of heap used) in the log entry whenever sleep threshold had exceeded a lot. It could be helpful. On Wed, May 9, 2018 at 11:26 AM, Patrick Hunt wrote: > On Wed, May 9, 2018 at 11:11 AM,

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Patrick Hunt
On Wed, May 9, 2018 at 11:11 AM, Norbert Kalmar wrote: > Thanks Patrick, great question. > My understanding is that this tool not only shows if JVM spends too much > time in GC, but if, for any other reason, there is a JVM pause (The tool > only differentiates GC pause from all other pause). This

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Norbert Kalmar
Thanks Patrick, great question. My understanding is that this tool not only shows if JVM spends too much time in GC, but if, for any other reason, there is a JVM pause (The tool only differentiates GC pause from all other pause). This could be slow fsync (although we do have logs for that) or even

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Patrick Hunt
Do you know why they did this rather than just enabling GC logging by default? Why re-invent the wheel? I seem to remember seeing a push do enable GC logging by default a few years ago. In particular around the time when the JVM added GC log rolling as a feature. Here's an example: https://batmat.

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Andor Molnar
+1 cool! On Wed, May 9, 2018 at 7:59 AM, Norbert Kalmar wrote: > Okay, thanks Ed, I created the Jira, will look into it soon :) > https://issues.apache.org/jira/browse/ZOOKEEPER-3037 > > Regards, > Norbert > > On Wed, May 9, 2018 at 4:44 PM Edward Ribeiro > wrote: > > > +1. Sounds really nice

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Norbert Kalmar
Okay, thanks Ed, I created the Jira, will look into it soon :) https://issues.apache.org/jira/browse/ZOOKEEPER-3037 Regards, Norbert On Wed, May 9, 2018 at 4:44 PM Edward Ribeiro wrote: > +1. Sounds really nice to have feature. Let's open a ticket and open a PR. > :) > > Ed > > Em qua, 9 de mai

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Edward Ribeiro
+1. Sounds really nice to have feature. Let's open a ticket and open a PR. :) Ed Em qua, 9 de mai de 2018 11:15, Norbert Kalmar escreveu: > Hi, > > I just got a tip that we could improve on the logging in ZooKeeper. After a > ZK crash, or client timeout sometimes it's hard to determine from the

[SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Norbert Kalmar
Hi, I just got a tip that we could improve on the logging in ZooKeeper. After a ZK crash, or client timeout sometimes it's hard to determine from the logs what happened. Knowing if ZK was responsive at the time would help a lot. For example, ZK might spend a lot of time waiting on GC (there is sti