[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297257#comment-16297257 ] Hudson commented on ZOOKEEPER-2893: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3665 (See

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294827#comment-16294827 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on the issue:

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292967#comment-16292967 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292545#comment-16292545 ] Hadoop QA commented on ZOOKEEPER-2893: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292541#comment-16292541 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user paulmillar commented on a diff in

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-15 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292522#comment-16292522 ] Andor Molnar commented on ZOOKEEPER-2893: - [~paulmillar] Done. Let's move this review to

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-14 Thread Paul Millar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291327#comment-16291327 ] Paul Millar commented on ZOOKEEPER-2893: Yes, that sounds fine. One final thing: log4j has a

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-14 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291144#comment-16291144 ] Andor Molnar commented on ZOOKEEPER-2893: - [~paulmillar] I've created a separate 'if' for

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290951#comment-16290951 ] Hadoop QA commented on ZOOKEEPER-2893: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290905#comment-16290905 ] Hadoop QA commented on ZOOKEEPER-2893: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290884#comment-16290884 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290883#comment-16290883 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-14 Thread Paul Millar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290571#comment-16290571 ] Paul Millar commented on ZOOKEEPER-2893: Catching NoRouteToHostException would be good, but

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290147#comment-16290147 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user phunt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290148#comment-16290148 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user phunt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289437#comment-16289437 ] Andor Molnar commented on ZOOKEEPER-2893: - [~paulmillar] I thought about it, but that would

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread Paul Millar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289222#comment-16289222 ] Paul Millar commented on ZOOKEEPER-2893: The other thing that would be good to fix is that the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289186#comment-16289186 ] Hadoop QA commented on ZOOKEEPER-2893: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288941#comment-16288941 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288924#comment-16288924 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288909#comment-16288909 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user paulmillar commented on a diff in

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288908#comment-16288908 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user paulmillar commented on a diff in

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288906#comment-16288906 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- Github user paulmillar commented on a diff in

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287649#comment-16287649 ] Hadoop QA commented on ZOOKEEPER-2893: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287625#comment-16287625 ] Andor Molnar commented on ZOOKEEPER-2893: - [~paulmillar] please check it > very poor choice

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287622#comment-16287622 ] ASF GitHub Bot commented on ZOOKEEPER-2893: --- GitHub user anmolnar opened a pull request:

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-12-12 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287581#comment-16287581 ] Andor Molnar commented on ZOOKEEPER-2893: - [~paulmillar] I'll take a look and submit a pull

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-09-19 Thread Paul Millar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171675#comment-16171675 ] Paul Millar commented on ZOOKEEPER-2893: ... just to add my 2c-worth Sure,

[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server

2017-09-14 Thread maoling (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167189#comment-16167189 ] maoling commented on ZOOKEEPER-2893: it is an unexpected exception:NoRouteToHostException, so