[
https://issues.apache.org/jira/browse/ZOOKEEPER-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3157.
-------------------------------------
Resolution: Fixed
Issue resolved by pull request 657
[https://github.com/apache/zookeeper/pull/657]
> Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection
> loss
> ----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3157
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3157
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
> Affects Versions: 3.6.0
> Reporter: Fangmin Lv
> Assignee: Andor Molnar
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> [~hanm] noticed that the test might failure because of ConnectionLoss when
> trying to getData, [here is an
> example|https://builds.apache.org/job/ZooKeepertrunk/198/testReport/junit/org.apache.zookeeper.server.quorum/FuzzySnapshotRelatedTest/testPZxidUpdatedWhenLoadingSnapshot],
> we should catch this and retry to avoid flaky.
> Internally, we 'fixed' flaky test by adding junit.RetryRule in ZKTestCase,
> which is the base class for most of the tests. I'm not sure this is the right
> way to go or not, since it's actually 'hiding' the flaky tests, but this will
> help reducing the flaky tests a lot if we're not going to tackle it in the
> near time, and we can check the testing history to find out which tests are
> flaky and deal with them separately. So let me know if this seems to provide
> any benefit in short term, if it is I'll provide a patch to do that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
